Skip to content

Fix load/store safety comments to require aligned T #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 11, 2023
Merged

Fix load/store safety comments to require aligned T #383

merged 1 commit into from
Dec 11, 2023

Conversation

programmerjake
Copy link
Member

Fixes: #382

@programmerjake
Copy link
Member Author

afaict nothing uses load or store with totally unaligned pointers, so this change is safe.

@programmerjake
Copy link
Member Author

tests failing because exposed_provenance was apparently split out of the strict_provenance feature gate.

@calebzulawski calebzulawski merged commit 1273da6 into rust-lang:master Dec 11, 2023
@RalfJung
Copy link
Member

tests failing because exposed_provenance was apparently split out of the strict_provenance feature gate.

Yes, that was rust-lang/rust#118487.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@workingjubilee workingjubilee Awaiting requested review from workingjubilee

@calebzulawski calebzulawski Awaiting requested review from calebzulawski

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Simd::load implementation does not match documentation

3 participants

@programmerjake @RalfJung @calebzulawski