Skip to content

Conversation

@sfackler
Copy link
Member

@sfackler sfackler commented Jan 17, 2018

This fixes a couple of typos and updates things to match the current implementation.

See rust-lang/cargo#4836 and rust-lang/cargo#4880.

cc @withoutboats @carols10cents @alexcrichton

@Centril Centril added T-cargo Relevant to the Cargo team, which will review and decide on the RFC. not-rfc For PRs that fix things like spelling mistakes, wrong file names, etc. labels Jan 17, 2018
@est31
Copy link
Member

est31 commented Jan 18, 2018

@sfackler want to incorporate changes for another bugfix as well? rust-lang/crates.io#1168

Copy link
Member

@carols10cents carols10cents left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussions in rust-lang/cargo#4880 need to be resolved and the resolution reflected here before this can be merged.

registry; the registry format is specified in the [Registry Index Format Specification
section][registry-index-format-specification].
Every registry has a name, specified in the `config.json` file in its index. The name specified
must match the registry's configured name. The URL specified should contain the location of the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requiring every registry to have a unique name will cause problems as outlined by alex in this comment:

Now one thing I don't like about custom names though is that it's possible to have two disjoint communities that both name their registry foo. This in turn can cause confusion and is a symptom of the fact that there's no one arbitrarting handing out names of registries.

@alexcrichton
Copy link
Member

@sfackler just to confirm, but if we end up going with rust-lang/cargo#4957 would you still want to switch to using names everywhere like in this RFC?

@sfackler
Copy link
Member Author

Yep - the objective here is to sync the RFC up with the implementation, not to push in one direction or another.

@alexcrichton
Copy link
Member

@sfackler oh but today I think the RFC is currently correct, right? In that urls are stored for dependencies in the index? (I don't think Cargo currently parses the allowed-registries key)

@sfackler
Copy link
Member Author

There are some other fixes in here. I'll update to just include those.

@sfackler
Copy link
Member Author

Updated

@sfackler sfackler force-pushed the alt-registries-tweaks branch from 4c6d512 to 203c644 Compare January 18, 2018 20:33
@alexcrichton alexcrichton merged commit 743efe4 into rust-lang:master Jan 19, 2018
@alexcrichton
Copy link
Member

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

not-rfc For PRs that fix things like spelling mistakes, wrong file names, etc. T-cargo Relevant to the Cargo team, which will review and decide on the RFC.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants