Skip to content

RFC: Templating CARGO_TARGET_DIR to make it the parent of all target directories #3371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 67 commits into from
Closed

RFC: Templating CARGO_TARGET_DIR to make it the parent of all target directories #3371

Changes from all commits
Commits
Show all changes
67 commits
Select commit Hold shift + click to select a range
4faf132
rfc: CARGO_TARGET_DIRECTORIES: initial proposal version
poliorcetics Jan 12, 2023
0a0df4c
chore: use PR number in file name
poliorcetics Feb 5, 2023
0b53b39
feat: Improve "alternatives" and "prior art" sections following review.
poliorcetics Feb 5, 2023
6082243
nit: clarify some lines
poliorcetics Feb 27, 2023
ed55d46
fix: improve bazel section, fix missing link
poliorcetics Feb 27, 2023
5f869bc
feat: use hashing in the naming scheme
poliorcetics Feb 27, 2023
aafee1c
feat: discuss remapping
poliorcetics Feb 27, 2023
4c89e34
nit: missing `<hash>`
poliorcetics Feb 28, 2023
a3b8c7c
fix: decisively declare non-stability of naming scheme
poliorcetics Feb 28, 2023
4ea813c
feat: talk about symlinks resolving
poliorcetics Feb 28, 2023
a8fae16
nit: clarify `cargo clean` behaviour explanation
poliorcetics Feb 28, 2023
f2a8448
fix: link to targo and add backlinks subsection
poliorcetics Feb 28, 2023
bd8b690
Expand on using `CARGO_TARGET_DIRECTORIES` as the default
poliorcetics May 28, 2023
7a1ee20
Clarify we hash on the symlink-resolved form of the path
poliorcetics May 28, 2023
35e99f6
rename CARGO_TARGET_DIRECTORIES to CARGO_TARGET_BASE_DIR
poliorcetics Jun 19, 2023
c2300bb
rename file to follow feature renaming
poliorcetics Jun 19, 2023
4a6cb64
question: how do we handle possibly thousand of directories in the sa…
poliorcetics Jun 19, 2023
7ac2013
clarify situation for third party cargo tools
poliorcetics Jun 19, 2023
b1aa45e
typo: dire -> directory
poliorcetics Jun 19, 2023
3676816
clarify CARGO_HOME as target base dir
poliorcetics Jun 19, 2023
0520ea8
don't use line breaks, they make following changes harder since they …
poliorcetics Jun 19, 2023
f604f0a
expand upon targo caching scheme
poliorcetics Jun 19, 2023
d7830f3
propose alternate naming scheme to simply scaling in unresolved quest…
poliorcetics Jun 19, 2023
e79c752
underspecify naming scheme and use manifest instead of workspace dir,…
poliorcetics Jun 21, 2023
a245144
Clarify one advantage
poliorcetics Jun 21, 2023
a7af623
Add drawback about windows path length limits
poliorcetics Jun 25, 2023
001f27f
keeping local target dir even if the default changes
poliorcetics Jun 25, 2023
e3fda64
Typo fix
poliorcetics Jun 27, 2023
5d33e78
introduce backlinks and expand on them
poliorcetics Jul 8, 2023
46f4b80
mention garbage collection in future possibilities
poliorcetics Jul 8, 2023
10e2d19
nit: fix unclear text
poliorcetics Sep 3, 2023
c386c97
clarify text about setting `CARGO_TARGET_DIR` for cargo calls
poliorcetics Sep 3, 2023
a519e7c
clarify backlinks and forward links, I misunderstood them at first
poliorcetics Sep 4, 2023
50251e4
cleanup of RFC text to make less use of 'I', 'we', add a link to targ…
poliorcetics Sep 4, 2023
0e5d30e
feat: move to templating `CARGO_TARGET_DIR` instead of a new config `…
poliorcetics Feb 17, 2024
9e119ef
fix: add transition period notice
poliorcetics Feb 17, 2024
d4fd860
rename file to follow feature rename
poliorcetics Feb 18, 2024
9945d9a
nit: missed BASE_
poliorcetics Feb 18, 2024
d222d65
point to the discussion on garbage collection
poliorcetics Feb 18, 2024
aea0adb
expand on exposing template metadata
poliorcetics Feb 18, 2024
376c306
caching in cargo home discussion
poliorcetics Feb 18, 2024
befae7d
move forward links sections to Unresolved questions
poliorcetics Feb 18, 2024
07f899b
specify link-target-dir
poliorcetics Feb 18, 2024
fac2d9c
Explain the advantages of hashes over copied folder tree structure
poliorcetics Feb 19, 2024
23ae70a
fix: put section back where it belong, it was one level too deep
poliorcetics Feb 19, 2024
025b8ef
drawback: brace expansion
poliorcetics Feb 19, 2024
8d1ddc2
future possibilities: remove section about metadata since there is no…
poliorcetics Feb 19, 2024
b81b3ed
link to issue 1734 for other possible templates discussions
poliorcetics Feb 19, 2024
2ae536e
fix link to garbage collection issue
poliorcetics Feb 19, 2024
11ab0e3
delete section about providing backlinks
poliorcetics Feb 19, 2024
6540d11
expand a lot on forward links, adding them to the RFC and not just as…
poliorcetics Feb 19, 2024
1195538
default with template fix
poliorcetics Feb 19, 2024
3cead0d
nit: simplify section title for template variables
poliorcetics Mar 22, 2024
3a6fa3e
nit: no double negatives
poliorcetics Mar 22, 2024
645d9c4
nit: clarify the point about path length as an argument for hashes
poliorcetics Mar 23, 2024
05b96f8
clarify summary by being more explicit (and fix a typo)
poliorcetics Mar 23, 2024
226f9ec
nit: fix a forgotten 'target-base-dir' remnant
poliorcetics Mar 23, 2024
2802659
feat: only one new option, not two, handle concurrent builds predictably
poliorcetics Mar 23, 2024
d879751
feat: clarify template-as-default section in future possibilites
poliorcetics Mar 23, 2024
0f71cf5
nit: remove nonsense line
poliorcetics Mar 24, 2024
927226d
nit: move transition period section
poliorcetics Mar 24, 2024
a821d25
feat: expand on transition period
poliorcetics Mar 24, 2024
5dcfb29
feat: mention key for a future default cargo default target directory
poliorcetics Mar 25, 2024
774e328
chore: move Transition Period section to reference level explanation
poliorcetics Mar 25, 2024
81bac72
feat: clarify the 'Naming' section
poliorcetics Apr 19, 2024
0a38c07
nit: forgotten 'an'
poliorcetics Apr 19, 2024
d549cb1
feat: add future possibilities for templating other configs
poliorcetics Apr 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading