Skip to content

Conversation

@epage
Copy link
Contributor

@epage epage commented Jan 19, 2024

@epage epage added the T-testing-devex Relevant to the testing devex team, which will review and decide on the RFC label Jan 19, 2024
@epage
Copy link
Contributor Author

epage commented Jan 19, 2024

Had to create the T-testing-devex label. Hope there isn't any other process for when we do the FCP...

EDIT: rust-lang/team#1238 unblocks FCP

@epage
Copy link
Contributor Author

epage commented Jan 30, 2024

@rfcbot merge

As we aren't gathering more input, figure its time to move forward.

@rfcbot
Copy link

rfcbot commented Jan 30, 2024

Team member @epage has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Currently awaiting signoff of all team members in order to enter the final comment period. disposition-merge This RFC is in PFCP or FCP with a disposition to merge it. final-comment-period Will be merged/postponed/closed in ~10 calendar days unless new substational objections are raised. labels Jan 30, 2024
@rfcbot
Copy link

rfcbot commented Jan 31, 2024

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot removed the proposed-final-comment-period Currently awaiting signoff of all team members in order to enter the final comment period. label Jan 31, 2024
@calebcartwright
Copy link
Member

I anticipate checking my box on this later today, but haven't fully finished reading the text yet

@rfcbot rfcbot added finished-final-comment-period The final comment period is finished for this RFC. to-announce and removed final-comment-period Will be merged/postponed/closed in ~10 calendar days unless new substational objections are raised. labels Feb 10, 2024
@rfcbot
Copy link

rfcbot commented Feb 10, 2024

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

@Muscraft Muscraft merged commit 309571f into rust-lang:master Feb 12, 2024
@Muscraft
Copy link
Member

Huzzah! The @rust-lang/testing-devex team has decided to accept this RFC.

To track further discussion, subscribe to the tracking issue here:
rust-lang/testing-devex-team#1

@epage epage deleted the libtest-json branch February 12, 2024 16:27
Muscraft added a commit to Muscraft/rfcs that referenced this pull request Feb 12, 2024
ehuss added a commit that referenced this pull request Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

disposition-merge This RFC is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this RFC. T-testing-devex Relevant to the testing devex team, which will review and decide on the RFC to-announce

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants