feat: Add toggle to disable cache priming #10810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lnicola
commented
Nov 19, 2021
crates/rust-analyzer/src/config.rs
Outdated
| joinLines_joinAssignments: bool = "true", | ||
|
|
||
| /// Pre-fill caches on project load. | ||
| load_prefillCaches: bool = "true", |
There was a problem hiding this comment.
rust-analyzer.cache.prefill?
There was a problem hiding this comment.
This is often called cache warmup.
There was a problem hiding this comment.
rust-analyzer.cache.warmup would also be good.
lnicola
changed the title
lnicola
force-pushed
the
optional-priming
branch
2 times, most recently
from
a118e08 to
c62e500
Compare
lnicola
force-pushed
the
optional-priming
branch
from
c62e500 to
a68ce62
Compare
|
bors r+ |
This was referenced Dec 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even if it doesn't prevent the rest of the features from working, cache priming tends to be quite CPU-intensive and can make people think that the load times are worse than they actually are.
It's also less useful in Code and
rust-toolsbecause the inlay hints and semantic highlighting trigger quite a bit of computation assuming you have a file open in the editor.