Skip to content

Conversation

@DaniPopes
Copy link
Contributor

A minor refactor of hover_simple opportunity I noticed while skimming through the code.

  • if lets -> match
  • iter::once(x).cycle -> iter::repeat
  • classify_token -> classify_node

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 24, 2023
@HKalbasi
Copy link
Member

Thanks!
@bors r+

@bors
Copy link
Contributor

bors commented Sep 24, 2023

📌 Commit 588c7d9 has been approved by HKalbasi

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Sep 24, 2023

⌛ Testing commit 588c7d9 with merge 862a300...

@bors
Copy link
Contributor

bors commented Sep 24, 2023

☀️ Test successful - checks-actions
Approved by: HKalbasi
Pushing 862a300 to master...

@bors bors merged commit 862a300 into rust-lang:master Sep 24, 2023
@DaniPopes DaniPopes deleted the hover-simple-refactor branch September 24, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants