feat: Allow cargo check to run on only the current package #16510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
|
@bors r+ |
|
☀️ Test successful - checks-actions |
davidbarsky
reviewed
Feb 8, 2024
|
|
||
| let mut load = |path: &AbsPath| { | ||
| let _p = tracing::span!(tracing::Level::INFO, "switch_workspaces::load").entered(); | ||
| let _p = tracing::span!(tracing::Level::DEBUG, "switch_workspaces::load").entered(); |
There was a problem hiding this comment.
it's up to you, but this change means that hprof won't pick up on this span.
There was a problem hiding this comment.
My base logs became completely useless due to that trace hence the change. Should be fine not to have that included in hprof
|
Not sure, this only solves the problem for cargo based workspaces. Not for full command overrides. |
This was referenced Apr 23, 2024
This was referenced May 9, 2024
This was referenced May 28, 2024
This was referenced Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc #13336, #12882