Skip to content

Conversation

@ChosenName
Copy link
Contributor

There are a lot of options that are a part of rust-analyzer, sometimes it can be hard to find an option that you are looking for. To fix this I have put all configurations into categories based on their names. I have also changed the schema in crates/rust-analyzer/src/config.rs to reflect this.

Currently for each generated entry the title is redeclared, this does function but I am prepared to change this if it is a problem.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 5, 2024
@Veykril
Copy link
Member

Veykril commented Jun 6, 2024

Sounds reasonable, we can tweak this afterwards if need be, thanks!
@bors r+

@bors
Copy link
Contributor

bors commented Jun 6, 2024

📌 Commit 14df2a4 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jun 6, 2024

⌛ Testing commit 14df2a4 with merge 577b0be...

@bors
Copy link
Contributor

bors commented Jun 6, 2024

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 577b0be to master...

1 similar comment
@bors
Copy link
Contributor

bors commented Jun 6, 2024

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 577b0be to master...

@bors bors merged commit 577b0be into rust-lang:master Jun 6, 2024
@bors
Copy link
Contributor

bors commented Jun 6, 2024

👀 Test was successful, but fast-forwarding failed: 422 Changes must be made through a pull request.

@mibes404
Copy link

@ChosenName this is really good.

Can these categories be shown and hidden dynamically?

Right now, user-oriented high-level settings like inlayHints are mixed in with highly technical low-level settings like lru capacity. It would be nice to have a drop-down menu to select a typical user profile, which would then show settings depending on the user profile: basic, power, or advanced. That way, the amount of settings can be limited to what a typical user in that category needs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants