Split out ExpressionStore from Body
#19036
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Veykril
force-pushed
the
push-nprltlwvryxw
branch
2 times, most recently
from
b19aef2 to
a3e1de1
Compare
Veykril
force-pushed
the
push-nprltlwvryxw
branch
from
a3e1de1 to
3bb0ff3
Compare
Veykril
commented
Jan 26, 2025
Comment on lines
+932
to
+935
| // can't actually have generics currently, but they might in the future | ||
| // More importantly, this completes the set of items that contain type references | ||
| // which is to be used by the signature expression store in the future. | ||
| StaticId(StaticId), |
Member
Author
There was a problem hiding this comment.
Everything in this PR is basically just moving and renaming parts except for this. If we don't put static in here we'd need to create an entirely new id enum that is effectively GenericDefId but with Static. I don't feel like we gain anything from such a split and it should simplify the coming changes a bunch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple refactor that can be split out for the #7434 work