fix: Fix off-by-one error in RangeFormatting #19124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
oh, i was confused. RA never does IO. the editor takes the returned JSON and applies it to the file. so this is testing everything it should, just a little indirectly. |
jyn514
force-pushed
the
range-fmt-off-by-one
branch
from
e7fe148 to
85d4823
Compare
jyn514
force-pushed
the
range-fmt-off-by-one
branch
from
85d4823 to
56dd8d1
Compare
jyn514
force-pushed
the
range-fmt-off-by-one
branch
from
56dd8d1 to
66253b6
Compare
jyn514
added a commit
to jyn514/dotfiles
that referenced
this pull request
Feb 9, 2025
- fix indent detection - keybinding for triggering completion - fix false error running remote-git-url - show line/column in statusbar - show blame for current line - add keybinding to format whole file - enable range formatting on nightly - note this won't work until rust-lang/rust-analyzer#19124 is merged
Veykril
reviewed
Feb 10, 2025
Veykril
approved these changes
Feb 10, 2025
|
Thanks! |
lnicola
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #19123.