Skip to content

Conversation

@Shourya742
Copy link
Contributor

Add doc to proc-macro-api crate.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 10, 2025
@Shourya742 Shourya742 force-pushed the 2025-03-10-add-proc-macro-api-doc branch from b29f507 to 3546ef2 Compare March 10, 2025 13:13
@Shourya742
Copy link
Contributor Author

r? @ChayimFriedman2

@ChayimFriedman2
Copy link
Contributor

@Shourya742 Is there a specific reason you are requesting a review from me? I'm not that knowledgeable in that part of r-a.

@Shourya742
Copy link
Contributor Author

@Shourya742 Is there a specific reason you are requesting a review from me? I'm not that knowledgeable in that part of r-a.

I had all my PRs reviewed by you, so I wanted to check with you first. Could you kindly let me know whom I should ping for this?

@ChayimFriedman2
Copy link
Contributor

Well generally @Veykril is the team lead so he can probably review this. But as a general rule you don't need to ping; the PR will be reviewed when someone with the capacity will find the time (time should be short for such small PR; if you didn't get a review in a week you can ask).

@Veykril
Copy link
Member

Veykril commented Mar 17, 2025

Well generally @Veykril is the team lead so he can probably review this.

To be clear, just because I am the team lead doesn't mean I have to review everything 😬 (I assume you didn't mean to imply that but either way)

As Chayim said, review times vary from PR to PR and depend on reviewer capacity

@Veykril Veykril added this pull request to the merge queue Mar 17, 2025
Merged via the queue into rust-lang:master with commit 64d39c1 Mar 17, 2025
9 checks passed
@Shourya742 Shourya742 deleted the 2025-03-10-add-proc-macro-api-doc branch March 17, 2025 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants