display varargs in completion detail #19363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Veykril
reviewed
Mar 15, 2025
Comment on lines
330
to
331
| params_display(ctx, func), | ||
| if func.is_varargs(ctx.db) { ", ..." } else { "" } |
Member
There was a problem hiding this comment.
Let's add that change to params_display. Might even be better to change this to not have params_display allocate a separate string here in the first place, that is use format_to for params_display (instead of format!).
Contributor
Author
There was a problem hiding this comment.
Done. Passing a mutable string to params_display seemed a bit messy to me compared to the gains, so I left as-is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the varargs are ignored, making the function signatures misleading.