fix: don't drop references with more than one definition. #19515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
jrmuizel
force-pushed
the
multiple-definitions
branch
2 times, most recently
from
b8e485a to
238186c
Compare
Veykril
reviewed
Apr 4, 2025
jrmuizel
force-pushed
the
multiple-definitions
branch
from
238186c to
fede4c7
Compare
Implicit field references during struct initialization were being dropped because get_definition was returning None because there were multiple definitions. This adds a new helper, `get_defintions`, that supports returning more than one definition for a given token and hooks it up. Fixes rust-lang#19393
jrmuizel
force-pushed
the
multiple-definitions
branch
from
fede4c7 to
e9d997e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implicit field references during struct initialization were being dropped because get_definition was returning None because there were multiple definitions.
This adds a new helper,
get_defintions, that supports returning more than one definition for a given token and hooks it up.Fixes #19393