Skip to content

internal: Support specific tags for PGO #19618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 18, 2025
Merged

internal: Support specific tags for PGO #19618

merged 1 commit into from
Apr 18, 2025

Conversation

@lnicola
Copy link
Member

@lnicola lnicola commented Apr 18, 2025 •
edited
Loading

This should make the builds more reproducible.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 18, 2025
@lnicola
Copy link
Member Author

lnicola commented Apr 18, 2025

r? @Kobzol

@rustbot
Copy link
Collaborator

rustbot commented Apr 18, 2025

Failed to set assignee to Kobzol: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

Kobzol
Kobzol reviewed Apr 18, 2025
View reviewed changes
Copy link
Member

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea!

@lnicola lnicola enabled auto-merge April 18, 2025 10:06
@lnicola lnicola added this pull request to the merge queue Apr 18, 2025
Merged via the queue into rust-lang:master with commit 16745db Apr 18, 2025
14 checks passed
@lnicola lnicola deleted the pgo-revision branch April 18, 2025 10:21
@lnicola lnicola changed the title internal: Support specific revisions for PGO internal: Support specific tags for PGO Apr 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Kobzol Kobzol Kobzol approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lnicola @rustbot @Kobzol