-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat: add "Generate blanket trait impl" assist #19771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add "Generate blanket trait impl" assist #19771
Conversation
9ebc4f2 to
670caf7
Compare
670caf7 to
3edcb5a
Compare
This comment was marked as resolved.
This comment was marked as resolved.
1d0a530 to
0ea1a84
Compare
|
@Veykril May I ask if these PRs can be merged? |
|
r? @Veykril |
01dab07 to
14f3de3
Compare
This comment has been minimized.
This comment has been minimized.
b0cf5ee to
fc71616
Compare
|
I think this overlaps with #19938? Though this adds blanket impls but I think they share lots of codes and we could reduce duplicates |
I compared the differences between these two and it doesn't seem like there's much shared code |
|
Okay, I'll look into this more but it might take some time as I have other works for now 😅 |
7094a81 to
109da7a
Compare
109da7a to
14d3192
Compare
|
@ShoyuVanilla Do you have time to review this PR? |
|
Sorry, not yet (I've been sick these days 😅 ) I'll review this tomorrow. |
|
Okay, thank you for taking the time to review |
Close #19768
This is very convenient for extending traits such as
IteratorAssist: generate_blanket_trait_impl
Generate blanket trait implementation.
->