feat: add "Remove else branches" assist

[A4-Tacks]

Removes the else keyword and else branches.

fn main() {
    if true {
        let _ = 2;
    } $0else {
        unreachable!();
    }
}

->

fn main() {
    if true {
        let _ = 2;
    }
}

---

fn main() {
    let _x = 2 $0else { unreachable!() };
}

->

fn main() {
    let _x = 2;
}

[ShoyuVanilla]

Should this be triggered on let else statements? I think most let else statements' else branch is not unreachable and removing them will result in compilation errors

[A4-Tacks]

Can be used for operations after refactoring into irrefutable pattern

[Veykril]

I think we can combine this with the unwrap block assist which has a similar purpose?

[A4-Tacks]

I think we can combine this with the unwrap block assist which has a similar purpose?

I don't quite understand, what should I do?

[Veykril]

We have this unwrap block assist here https://github.com/rust-analyzer/rust-analyzer/blob/c5181dbbe33af6f21b9d83e02fdb6fda298a3b65/crates/ide-assists/src/handlers/unwrap_block.rs

which I just realized already does what this assist does I believe? If you put the cursor on the else block's braces it pops up there

Though it does not trigger for let else yet

[A4-Tacks]

We have this unwrap block assist here

If it is applicable to let-else, it may be strange:

For example:

let Some(x) = val else {$0 return false; };

Possible output one:

return false;

This seems niche enough

Possible output two:

let Some(x) = val;

This does not match the name of the unwrap block

Though it does not trigger for let else yet

Do I need to trigger remove_else_branches on the l_curly of let-else as well?

[Veykril]

Ah right, the assist does have a different intent than this one, nevermind then.

[A4-Tacks]

What do I need to do?

• Move the assist of 'apply for let-else' to 'Unwrap block'?

  • Implement Possible output one?
  • Implement Possible output two?

• Apply this assist to l_curly?

[Veykril]

Nothing, disregard my earlier comment its not applicable to this after all.