fix: Fix proc macro server handling of strings with minuses #19970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It used to decompose them thinking they were numbers.
rustbot
added
the
S-waiting-on-review
lnicola
approved these changes
Jun 11, 2025
Veykril
approved these changes
Jun 11, 2025
Member
|
We should backport this, I think #19746 might be on beta already (checking right now) |
Member
|
Nevermind, the last sync that hit beta was april 28th |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It used to decompose them thinking they were numbers.
This arose from #19746.
Fixes #19965 (I checked it is indeed fixed, but this will have to wait for a sync).