feat: Add an option to hide reborrows in adjustment inlay hints #20520
Conversation
Reborrows are consecutive deref then ref. Make it the default because reborrows are mostly useless to the programmer. Also rename `rust-analyzer.inlayHints.expressionAdjustmentHints.enable: "reborrow"` to `rust-analyzer.inlayHints.expressionAdjustmentHints.enable: "borrows"`, as it's not about reborrows but about any ref/deref and it's confusing with the new setting.
rustbot
added
the
S-waiting-on-review
ShoyuVanilla
left a comment
ShoyuVanilla
left a comment
There was a problem hiding this comment.
It's a bit surprising that current "Reborrows" option has been enabling everything except pointer cast and never to any adjustments 😅
rustbot
removed
the
S-waiting-on-review
lnicola
changed the title
| #[derive(Clone, Debug, PartialEq, Eq)] | ||
| pub enum AdjustmentHints { | ||
| Always, | ||
| ReborrowOnly, |
There was a problem hiding this comment.
note this breaks user configs using the old key
There was a problem hiding this comment.
That's the inlay hints parameter, the real config has #[serde(alias)] for this reason.
There was a problem hiding this comment.
Hmm, I just used the pre-release and got an error about unrecognized config though
| #[serde(rename_all = "snake_case")] | ||
| enum AdjustmentHintsDef { | ||
| Reborrow, | ||
| #[serde(alias = "Reborrow")] |
There was a problem hiding this comment.
Oh maybe this must be reborrow? Not sure if rename_all applies to aliases
There was a problem hiding this comment.
It does not. I even thought about that, but somehow still wrote Reborrow. Created #20606 for that.
4 participants
Reborrows are consecutive deref then ref. Make it the default because reborrows are mostly useless to the programmer.
Also rename
rust-analyzer.inlayHints.expressionAdjustmentHints.enable: "reborrow"torust-analyzer.inlayHints.expressionAdjustmentHints.enable: "borrows", as it's not about reborrows but about any ref/deref and it's confusing with the new setting.Closes #20516.