fix: Expand literals with wrong suffixes into LitKind::Err
#20963
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20952
For ill-suffixed literals like
""б(Not a number6😅), we pass it asfmt_snippethere:rust-analyzer/crates/hir-def/src/hir/format_args.rs
Line 197 in 00b627d
But in that function the following line panics if the string literal has the suffix ending with a
char::len_utf8() > 1https://doc.rust-lang.org/1.91.0/nightly-rustc/src/rustc_parse_format/lib.rs.html#319
We might limplement some diagnostics or error recovery upon those ill-suffixed string literals but that's not quite doable without some non-trivial refactoring in our parser/token tree/expansion infra. The simplest fix would be just erroring on those literals