internal: Merge ungrammar into rust-analyzer
#20990
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow empty statement
Grammar updates
Typo fix on grammar documentation
I assumer that's why there were already parentheses around the `':' Type`?
Make type in Param optional
10: Allow type aliases in extern blocks r=jonas-schievink a=jonas-schievink This is for the unstable feature rust-lang/rust#43467, which rustc uses internally Co-authored-by: Jonas Schievink <[email protected]>
11: Allow both const & async modifiers r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
12: Fix .gitignore r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
48: Revert the visibility removal of macro_rules visibility (rust-lang#46) r=Veykril a=ChayimFriedman2 As discussed in rust-analyzer/ungrammar#46 (comment). Co-authored-by: Chayim Refael Friedman <[email protected]>
The supported patterns are already valid as expressions, except the rest pattern (`..`) and the wildcard pattern (`_`).
47: Support destructuring assignments (RFC 2909) r=Veykril a=ChayimFriedman2 The supported patterns are already valid as expressions, except the rest pattern (`..`) and the wildcard pattern (`_`). (We really should separate `rust.ungram` into the rust-analyzer repository, it blocks every syntax change). Co-authored-by: Chayim Refael Friedman <[email protected]>
50: Include `Self` specifically in NameRef r=Veykril a=Veykril `Self` is a keyword, so we'll treat it as such bors r+ Co-authored-by: Lukas Wirth <[email protected]>
Labels are followed by rules The ungrammar listed in https://rust-analyzer.github.io/blog/2020/10/24/introducing-ungrammar.html seems to be correct
Update ungrammar.ungram with proper labeled rule
Update repo link in Cargo.toml
implement `Clone` for `Rule`
rustbot
added
the
S-waiting-on-review
This comment was marked as resolved.
This comment was marked as resolved.
rustbot
added
has-merge-commits
S-waiting-on-author
Veykril
force-pushed
the
push-zzrzusnvwpzp
branch
2 times, most recently
from
df2e867 to
9c70e9d
Compare
Veykril
force-pushed
the
push-zzrzusnvwpzp
branch
from
9c70e9d to
df009ee
Compare
rustbot
removed
the
S-waiting-on-review
lnicola
changed the title
ungrammar into rust-analyzer ungrammar into rust-analyzer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
17 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pulls in https://github.com/rust-analyzer/ungrammar, moving maintenance into the main repo.