internal: Merge text-size into rust-analyzer
#20991
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's useful for cross-crate inlining
1: Add extend_to for TextRange r=edwin0cheng a=edwin0cheng ~~This PR added a `convex_hull` function for joining to two `TextUnit` together.~~ This PR added a `extend_to` function for joining to two `TextUnit` together. Co-authored-by: Edwin Cheng <[email protected]>
Large refactor: text-size almost-1.0 crate
This is in contrast to `std::ops::Range`, which are not guaranteed to be proper. For this reason, we have to lose `From` impls as well.
Proper ranges
The impl is valid, but probably not too useful, we can always add it later
Remove things
Add a couple of non-canonical ctors
43: fix typos r=CAD97 a=connorskees This fixes 3 small typos in the docs :) Co-authored-by: ConnorSkees <[email protected]>
42: Update README.md with the right title r=matklad a=bnjjj Co-authored-by: Coenen Benjamin <[email protected]>
44: Scope trait TextLen just for primitives r=matklad a=CAD97 As an alternative to rust-lang#41 I thought I posted this already.... Co-authored-by: CAD97 <[email protected]>
46: Fix TextSize::of docs to no longer suggest implementing TextLen r=matklad a=CAD97 Addresses the misleading docs part of rust-lang#45 by editing the docs back to their minimum. Does not yet provide advice on idioms for non-primitive types. Co-authored-by: CAD97 <[email protected]>
rustbot
added
the
S-waiting-on-review
This comment was marked as resolved.
This comment was marked as resolved.
rustbot
added
has-merge-commits
S-waiting-on-author
Veykril
force-pushed
the
push-rrpwmvnskstu
branch
from
4136430 to
f12388c
Compare
rustbot
removed
the
S-waiting-on-review
lnicola
changed the title
text-size into rust-analyzer text-size into rust-analyzer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pulls in https://github.com/rust-analyzer/text-size, moving maintenance into the main repo.