fix: make visibility diagnostics for fields to correct location #21018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Natural-selection1
force-pushed
the
visibility
branch
from
5a1df07 to
52df627
Compare
Natural-selection1
changed the title
A4-Tacks
reviewed
Nov 16, 2025
Natural-selection1
force-pushed
the
visibility
branch
from
52df627 to
1700dd3
Compare
ChayimFriedman2
approved these changes
Nov 17, 2025
Contributor
ChayimFriedman2
left a comment
ChayimFriedman2
left a comment
There was a problem hiding this comment.
LGTM, but note that we have a situation (see #21008) that we can't merge PRs currently, so not merging this yet.
Thanks!
Natural-selection1
force-pushed
the
visibility
branch
2 times, most recently
from
e11bb3c to
64a0772
Compare
Natural-selection1
force-pushed
the
visibility
branch
from
64a0772 to
6654b4e
Compare
Contributor
|
What's going on? |
Contributor
Author
|
I don't know why the changes disappeared Wait for me patiently for a few minutes : ) |
Natural-selection1
force-pushed
the
visibility
branch
from
6654b4e to
cc66e1d
Compare
Contributor
Author
|
I completely replicated the last commit before Marco Ieni's force-push |
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close: #21016