Implement bulitin line! macro #2205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matklad
reviewed
Nov 11, 2019
|
|
||
| assert_eq!(quoted.to_string(), "impl Clone for Foo {fn clone (& self) -> Self {Self {name : self . name . clone () , id : self . id . clone () ,}}}"); | ||
| } | ||
| } |
There was a problem hiding this comment.
Neat!
I am not sure if the amount of build-in macros really requires us to have quasy-quoting, but it definitely is wort to try!
I'd also would-like to have strongly-typed quasy-quoting for assists some day...
There was a problem hiding this comment.
If I remember correctly, we would like to expand builtin derive as normal macro expansion. A quasy quoting macro should help there. (Thats why I use Clone as a test case )
edwin0cheng
force-pushed
the
impl-builtin-line
branch
from
341ec79 to
4f7df2a
Compare
|
bors r+ Thanks! |
bors bot
added a commit
that referenced
this pull request
Nov 11, 2019
2205: Implement bulitin line! macro r=matklad a=edwin0cheng This PR implements bulitin macro `line!` and add basic infra-structure for other bulitin macros: 1. Extend `MacroDefId` to support builtin macros 2. Add a `quote!` macro for simple quasi quoting. Note that for support others builtin macros, eager macro expansion have to be supported first, this PR not try to handle it. :) Co-authored-by: Edwin Cheng <[email protected]>
Build succeeded |
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements bulitin macro
line!and add basic infra-structure for other bulitin macros:MacroDefIdto support builtin macrosquote!macro for simple quasi quoting.Note that for support others builtin macros, eager macro expansion have to be supported first, this PR not try to handle it. :)