Global module #234
Merged
Global module #234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convention: we prefix private queries with `_` until salsa support real visibility.
Contributor
Author
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 20, 2018
234: Global module r=matklad a=matklad This series of commits re-introdces `ModuleDescriptor` as one stop shop for all information about a module. Co-authored-by: Aleksey Kladov <[email protected]>
kjeremy
reviewed
Nov 20, 2018
| fn fn_syntax() for FnSyntaxQuery; | ||
| fn fn_scopes() for FnScopesQuery; | ||
| fn _fn_syntax() for FnSyntaxQuery; | ||
| fn _submodules() for SubmodulesQuery; |
Contributor
There was a problem hiding this comment.
Why the leading underscores?
Contributor
Author
There was a problem hiding this comment.
These are "private" queries. We currently can't use Rust visibility rules here, because salsa requires everything to be public.
kjeremy
reviewed
Nov 20, 2018
crates/ra_analysis/src/imp.rs
Outdated
| let source_root = self.db.file_source_root(file_id); | ||
| self.db.module_tree(source_root) | ||
| } | ||
| /// This return `Vec`: a module may be inclucded from several places. |
Contributor
Canceled |
Contributor
Author
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 20, 2018
234: Global module r=matklad a=matklad This series of commits re-introdces `ModuleDescriptor` as one stop shop for all information about a module. Co-authored-by: Aleksey Kladov <[email protected]>
Contributor
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series of commits re-introdces
ModuleDescriptoras one stop shop for all information about a module.