Skip to content

Conversation

@jonas-schievink
Copy link
Contributor

Includes a minor fixup to macro 2.0 parsing.

bors r+

@bors
Copy link
Contributor

bors bot commented Apr 3, 2021

@bors bors bot merged commit bf695c4 into rust-lang:master Apr 3, 2021
@jonas-schievink jonas-schievink deleted the panic-macro branch April 3, 2021 01:26
// Case 1: builtin macros
if attrs.by_key("rustc_builtin_macro").exists() {
// `#[rustc_builtin_macro = "builtin_name"]` overrides the `macro_rules!` name.
let name;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to delete ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it is assigned a tt::Ident below at line 1410. The next let name = then gets a reference to the tt::Ident as value at line 1411.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL ! Neat !

@lnicola
Copy link
Member

lnicola commented Apr 3, 2021

changelog fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants