feat: avoid checking the whole project during initial loading #8476
Conversation
8476: feat: avoid checking the whole project during initial loading r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
|
bors r- |
|
Canceled. |
|
bors r+ |
8476: feat: avoid checking the whole project during initial loading r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
|
Build failed: |
|
bors r+ |
|
Canceled. |
|
Fun fact -- took me a while to debug this, because cargo caches rustc invocations. So it cached the first, buggy implementation, and happy echoed buggy behavior at me and leaving me wondering why my bug fix doesn't work and why my logs don't show up. Guess who added this caching to cargo in the first place? |
|
Turns out that the cache proprely accounts for rustc's own mtime (pat on the back, @matklad!) but misses the wrappers specifically: rust-lang/cargo#9348 |
|
Just installed a binary of rust analyzer for neovim, made "main.rs" file empty and then opened it, it showed "cargo check failed" and tells me to press enter and then loops ............... |
|
@rishadbaniya please open a separate issuer with specific steps for reproduction, or ask more open-ended support questions in the forum: https://users.rust-lang.org/c/ide/14 |
matklad
force-pushed
the
wrapper
branch
4 times, most recently
from
68193d8 to
5a5a609
Compare
|
bors r+ |
| fn out_dirs_check() { | ||
| if skip_slow_tests() { | ||
| return; | ||
| // return; |
There was a problem hiding this comment.
Looks like you left this in by accident
There was a problem hiding this comment.
Good catch, fixed #8584.
I wonder if there's a better way to convenently run a single slow test from the editor that uncommenting the thing...
There was a problem hiding this comment.
Maybe an env var that RA can set similar to what we do for updating expect tests via command?
There was a problem hiding this comment.
The way I did :
fn out_dirs_check() {
if skip_slow_tests() {
// TODO:
// return;
}
}There was a problem hiding this comment.
Cool, didn't thought about that!
5 participants
bors r+
🤖