Skip to content

Conversation

Alexendoo
Copy link
Member

changelog: Fix error when providing an array-size-threshold in clippy.toml

Not entirely sure why it doesn't want to deserialize a u128, but converting it after the fact is an easy enough fix

Fixes #10422

@rustbot
Copy link
Collaborator

rustbot commented Feb 28, 2023

r? @Manishearth

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Feb 28, 2023
@poliorcetics
Copy link

That will need to be backported to beta, else the next version will be broken

@Alexendoo Alexendoo added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Feb 28, 2023
@flip1995
Copy link
Member

Thanks!

@bors r+

I'll deal with the backports on Thursday.

@bors
Copy link
Contributor

bors commented Feb 28, 2023

📌 Commit 53375ca has been approved by flip1995

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Feb 28, 2023

⌛ Testing commit 53375ca with merge b85b9ef...

bors added a commit that referenced this pull request Feb 28, 2023
Fix array-size-threshold config deserialization error

changelog: Fix error when providing an `array-size-threshold` in `clippy.toml`

Not entirely sure why it doesn't want to deserialize a u128, but converting it after the fact is an easy enough fix

Fixes #10422
@bors
Copy link
Contributor

bors commented Feb 28, 2023

💔 Test failed - checks-action_test

@Alexendoo Alexendoo force-pushed the array-size-threshold branch from 53375ca to 2cadea5 Compare February 28, 2023 14:37
@flip1995
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Feb 28, 2023

📌 Commit 2cadea5 has been approved by flip1995

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Feb 28, 2023

⌛ Testing commit 2cadea5 with merge acf70ea...

@bors
Copy link
Contributor

bors commented Feb 28, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing acf70ea to master...

1 similar comment
@bors
Copy link
Contributor

bors commented Feb 28, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing acf70ea to master...

@bors bors merged commit acf70ea into rust-lang:master Feb 28, 2023
@flip1995 flip1995 added beta-accepted Accepted for backporting to the compiler in the beta channel. and removed beta-nominated Nominated for backporting to the compiler in the beta channel. labels Mar 2, 2023
@flip1995
Copy link
Member

flip1995 commented Mar 2, 2023

rust-lang/rust#108673

@Alexendoo Alexendoo deleted the array-size-threshold branch March 2, 2023 22:12
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 4, 2023
[beta] stage0 bump and backports

- Bump stage0 to stable
- Revert to using `RtlGenRandom` as a fallback rust-lang#108060
- Fix `VecDeque::shrink_to` and add tests. rust-lang#108475
- Fix `VecDeque::append` capacity overflow for ZSTs rust-lang#108462
- Clippy: Fix array-size-threshold config deserialization error rust-lang#108673 / rust-lang/rust-clippy#10423
- Yeet point_at_expr_source_of_inferred_type for now rust-lang#108703

r? `@ghost`
@flip1995 flip1995 removed the beta-accepted Accepted for backporting to the compiler in the beta channel. label Mar 10, 2023
bors added a commit that referenced this pull request Mar 10, 2023
Update changelog for beta-accepted labels

Roses are red
Violets are blue
r? `@xFrednet` is better at this
I can't rhyme.

#10423
#10265

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nightly clippy fails on array-size-threshold
6 participants