Fix redundant_closure false positive with closures has return type contains 'static
#13108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
tesuji
force-pushed
the
fix_redundant_closure
branch
from
6062dbb to
84182ff
Compare
tesuji
force-pushed
the
fix_redundant_closure
branch
3 times, most recently
from
6fc6518 to
33d00b3
Compare
Contributor
|
☔ The latest upstream changes (presumably #13157) made this pull request unmergeable. Please resolve the merge conflicts. |
Also get the receiver T in `T.method(|| f())`.
tesuji
force-pushed
the
fix_redundant_closure
branch
from
33d00b3 to
0bc9f00
Compare
Member
|
Sorry for the long wait here, I don't have enough time to properly look into/review this atm, so I'm going to reroll to not block this any longer: r? clippy |
xFrednet
approved these changes
Aug 1, 2024
Contributor
|
Looks good to me, thank you for the fix and slight refactoring :D Roses are red, |
Contributor
Contributor
Contributor
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #13073 .
Please enable "ignore white-space change" settings in github UI for easy reviewing.
HACK: The third commit contains a hack to check if a type
T: 'staticwhenfn() -> U where U: 'static.I don't have a clean way to check for it.
changelog: [
redundant_closure] Fix false positive with closures has return type contains'static