New internal lint: repeated_is_diagnostic_item
#15937
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Collaborator
ada4a
changed the title
repeated_is_diagnostic_item
ada4a
commented
Oct 22, 2025
| @@ -0,0 +1,218 @@ | |||
| use crate::internal_paths::MAYBE_DEF; | |||
Contributor
Author
There was a problem hiding this comment.
The lint, thankfully, gives a bunch warnings on dogfood, but for some reason, cargo dev dogfood --fix doesn't seem to autofix them; I've checked that Applicability remains MachineApplicable even after all the suggestions are created.
Any ideas?
Contributor
Author
There was a problem hiding this comment.
I went ahead and applied the fixes by hand... Still, would like to avoid the need to do this in the future
ada4a
force-pushed
the
repeated_is_diagnostic_item
branch
from
c5c5bba to
706d519
Compare
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
rustbot
removed
the
S-waiting-on-review
ada4a
force-pushed
the
repeated_is_diagnostic_item
branch
from
706d519 to
0560075
Compare
rustbot
added
the
S-waiting-on-review
ada4a
force-pushed
the
repeated_is_diagnostic_item
branch
from
0560075 to
eae5601
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #15528 (comment)
changelog: none