Add lint to detect transmutes from float to integer #4889
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add lint that detects transmutation from a float to an integer
and suggests usage of `{f32, f64}.to_bits()` instead.
krishna-veerareddy
force-pushed
the
issue-3993-float-to-int-transmute
branch
from
fcf9b7f to
c77fc06
Compare
`transmute.stderr` file line count exceeded due to the new test cases so moving the new test cases into a separate file.
krishna-veerareddy
force-pushed
the
issue-3993-float-to-int-transmute
branch
from
e2ea939 to
23c03e4
Compare
|
Thank you! @bors r+ |
|
📌 Commit 23c03e4 has been approved by |
bors
added a commit
that referenced
this pull request
Dec 8, 2019
…smute, r=llogiq
Add lint to detect transmutes from float to integer
Add lint that detects transmutation from a float to an integer and suggests usage of `{f32, f64}.to_bits()` instead.
Fixes #3993
changelog: Add lint `transmute_float_to_int`
|
☀️ Test successful - checks-travis, status-appveyor |
This was referenced Dec 8, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add lint that detects transmutation from a float to an integer and suggests usage of
{f32, f64}.to_bits()instead.Fixes #3993
changelog: Add lint
transmute_float_to_int