Allow suboptimal_flops in const functions
#8009
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @giraffate (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
xFrednet
force-pushed
the
8004-suboptimal-flops-in-const
branch
from
0062f08 to
5a3f418
Compare
xFrednet
force-pushed
the
8004-suboptimal-flops-in-const
branch
from
5a3f418 to
1c8085d
Compare
giraffate
approved these changes
Nov 21, 2021
|
@bors r+ Thanks! |
|
📌 Commit 1c8085d has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows
clippy::suboptimal_flopsin constant functions. The check also effects theclippy::imprecise_flopslint logic. However, this doesn't have any effects as all functions checked for are not const and can therefore not be found in such functions.changelog: [
suboptimal_flops]: No longer triggers in constant functionsCloses: #8004