add cast-nan-to-int lint
#9617
Merged
add cast-nan-to-int lint
#9617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
Alexendoo
reviewed
Oct 10, 2022
llogiq
force-pushed
the
cast-nan-to-int
branch
from
d17e7fa to
5928b61
Compare
|
I've added the note you suggested. Anything else needed? |
|
☔ The latest upstream changes (presumably #9572) made this pull request unmergeable. Please resolve the merge conflicts. |
Alexendoo
approved these changes
Oct 11, 2022
llogiq
force-pushed
the
cast-nan-to-int
branch
from
5928b61 to
e4c80f2
Compare
|
Thank you for the review! |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #371.
r? @Alexendoo
changelog: add [
cast-nan-to-int] lint