Skip to content

Conversation

@koka831
Copy link
Contributor

@koka831 koka831 commented Nov 10, 2022

fix #9300

changelog: [cognitive_complexity] support async fn

@rust-highfive
Copy link

r? @Alexendoo

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 10, 2022
@Alexendoo
Copy link
Member

Thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Nov 10, 2022

📌 Commit 2bc04bd has been approved by Alexendoo

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Nov 10, 2022

⌛ Testing commit 2bc04bd with merge 4f1698d...

@bors
Copy link
Contributor

bors commented Nov 10, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Alexendoo
Pushing 4f1698d to master...

@bors bors merged commit 4f1698d into rust-lang:master Nov 10, 2022
@koka831 koka831 deleted the fix/9300 branch November 12, 2022 13:12
bors added a commit that referenced this pull request Nov 12, 2022
Fix is_async_fn to check FnKind::Method

This is a follow-up PR of #9828 to support also async methods.

changelog: [`cognitive_complexity`] support async method

r? `@Alexendoo`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cognitive complexity doesn't work for async functions

4 participants