Skip to content
This repository was archived by the owner on Aug 25, 2025. It is now read-only.

Conversation

Keruspe
Copy link
Contributor

@Keruspe Keruspe commented Apr 28, 2017

No description provided.

Signed-off-by: Marc-Antoine Perennou <[email protected]>
@Keruspe
Copy link
Contributor Author

Keruspe commented Apr 28, 2017

This is the first step for adding bindir support to rustbuild.
A concrete example of why it is needed:
On exherbo we install everything that is arch-specific in /usr/<arch>/{bin,lib,libexec} and everything arch-independant to /usr/share and friends.
With the current setup, mostly everything would install fine with rustbuild if we set the prefix to /usr/<arch> for example but some things like cargo's shell completions are wrongly installed inside /usr/<arch>/share.
If this gets accepted I'll send a followup pull request for doing the same with sysconfdir (same problem, bash completion gets installed to /usr/<arch>/etc. (Of course I can add that directly to this pull request, if you want)

Signed-off-by: Marc-Antoine Perennou <[email protected]>
@Keruspe Keruspe changed the title add --bindir support add --bindir and --sysconfdir support Apr 28, 2017
@Keruspe
Copy link
Contributor Author

Keruspe commented Apr 28, 2017

I figure it's just as easy to review both at the same time so I pushed the sysconfdir stuff too.

@alexcrichton
Copy link
Member

Thanks and sorry for the delay!

bors added a commit to rust-lang/rust that referenced this pull request May 16, 2017
rustbuild: add support for --bindir and --sysconfdir

This depends on rust-lang/rust-installer#59 and we'll need to udpate the rust-installer submodule once it gets merged for it to work

Fixes #41644
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants