Skip to content

Move clippy::uninlined_format_args back to pedantic #103654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2022
Merged

Move clippy::uninlined_format_args back to pedantic #103654

merged 1 commit into from
Oct 28, 2022

Conversation

@flip1995
Copy link
Member

Before beta is branched tomorrow we want to move this lint back to pedantic so that it is not enabled by default.

Clippy PR: rust-lang/rust-clippy#9728
Zulip discussion: https://rust-lang.zulipchat.com/#narrow/stream/257328-clippy/topic/.60uninlined_format_args.60.20category/near/306306974

r? @Manishearth

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 27, 2022
@rustbot
Copy link
Collaborator

rustbot commented Oct 27, 2022

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

@flip1995 flip1995 mentioned this pull request Oct 27, 2022
Merged
@Manishearth
Copy link
Member

@bors r+ p=4

@bors
Copy link
Collaborator

bors commented Oct 27, 2022

📌 Commit 3f24108 has been approved by Manishearth

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 27, 2022
@bors
Copy link
Collaborator

bors commented Oct 28, 2022

⌛ Testing commit 3f24108 with merge cdd7afe...

@est31 est31 mentioned this pull request Oct 28, 2022
Merged
@bors
Copy link
Collaborator

bors commented Oct 28, 2022

☀️ Test successful - checks-actions
Approved by: Manishearth
Pushing cdd7afe to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 28, 2022
@bors bors merged commit cdd7afe into rust-lang:master Oct 28, 2022
@rustbot rustbot added this to the 1.66.0 milestone Oct 28, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (cdd7afe): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.9% [-0.9%, -0.9%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -0.9% [-0.9%, -0.9%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Footnotes

  1. the arithmetic mean of the percent change ↩

  2. number of relevant changes ↩

@flip1995 flip1995 deleted the clippy_backport branch October 28, 2022 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Manishearth Manishearth

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.66.0

Development

Successfully merging this pull request may close these issues.

5 participants

@flip1995 @rustbot @Manishearth @bors @rust-timer