Skip to content

Add Nilstrieb to compiler reviewers #105534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 11, 2022
Merged

Add Nilstrieb to compiler reviewers #105534

merged 1 commit into from
Dec 11, 2022

Conversation

@Noratrieb
Copy link
Member

@Noratrieb Noratrieb commented Dec 10, 2022

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 10, 2022
wesleywiser
wesleywiser approved these changes Dec 10, 2022
View reviewed changes
Copy link
Member

@wesleywiser wesleywiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@wesleywiser
Copy link
Member

wesleywiser commented Dec 10, 2022

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Dec 10, 2022

📌 Commit 2704b75 has been approved by wesleywiser

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 10, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 10, 2022
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 10, 2022
@matthiaskrgr
Rollup merge of rust-lang#105534 - Nilstrieb:i-will-review-your-code,…
a78c0c7 
… r=wesleywiser

Add Nilstrieb to compiler reviewers

r? `@wesleywiser`
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 10, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 11, 2022
@bors
Auto merge of rust-lang#105543 - matthiaskrgr:rollup-s9zj0pq, r=matth…
e1c9121 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#103146 (Cleanup timeouts in pthread condvar)
 - rust-lang#105459 (Build rust-analyzer proc-macro server by default)
 - rust-lang#105460 (Bump compiler-builtins to 0.1.85)
 - rust-lang#105511 (Update rustix to 0.36.5)
 - rust-lang#105530 (Clean up lifetimes in rustdoc syntax highlighting)
 - rust-lang#105534 (Add Nilstrieb to compiler reviewers)
 - rust-lang#105542 (Some method confirmation code nits)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 3da198a into rust-lang:master Dec 11, 2022
@rustbot rustbot added this to the 1.68.0 milestone Dec 11, 2022
@Noratrieb Noratrieb deleted the i-will-review-your-code branch December 11, 2022 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wesleywiser wesleywiser wesleywiser approved these changes

Assignees

@wesleywiser wesleywiser

Labels

A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.68.0

Development

Successfully merging this pull request may close these issues.

4 participants

@Noratrieb @wesleywiser @bors @rustbot