Skip to content

Conversation

GuillaumeGomez
Copy link
Member

Part of #66181.

It extends the test so it's also run in mobile mode.

r? @notriddle

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Apr 7, 2023
@notriddle
Copy link
Contributor

notriddle commented Apr 7, 2023

I guess?

  • Does it make sense that this feature would not work on mobile?
  • Might it make sense to add an easier way to implement this pattern of running the goml test case at multiple sizes?

@GuillaumeGomez
Copy link
Member Author

Does it make sense that this feature would not work on mobile?

On desktop you mean?

Might it make sense to add an easier way to implement this pattern of running the goml test case at multiple sizes?

Do you have an idea in mind maybe?

@notriddle
Copy link
Contributor

On desktop you mean?

Either way, yes. Does the implementation of this feature actually involve the screen size?

Do you have an idea in mind maybe?

A header at the top of the file that lists screen sizes to test in.

@bors
Copy link
Collaborator

bors commented Apr 12, 2023

☔ The latest upstream changes (presumably #110194) made this pull request unmergeable. Please resolve the merge conflicts.

@GuillaumeGomez
Copy link
Member Author

After thinking about it, I think it's useless since there is no UI difference in here. Closing then.

@GuillaumeGomez GuillaumeGomez deleted the auto-hide-large-item-mobile branch April 12, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants