Migrate item_opaque_ty to Askama
#112034
Merged
Migrate item_opaque_ty to Askama
#112034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
Need to squash these two, but otherwise it looks good to go |
|
Looks all good to me. Let's just wait for #112030 (comment) to be solved first. |
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
approved these changes
Jun 3, 2023
|
Looks good to me, thanks! Please squash your commits then I'll r+ it. |
sladyn98
force-pushed
the
migrate-opaque-ty
branch
from
eae5df0 to
99442cf
Compare
This comment has been minimized.
This comment has been minimized.
Migrate item_opaque_type to Askama Fix wrap_item parameters Fix to write
sladyn98
force-pushed
the
migrate-opaque-ty
branch
from
99442cf to
29a51e1
Compare
|
Yeah squashed |
GuillaumeGomez
approved these changes
Jun 8, 2023
|
Thanks! @bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 8, 2023
…llaumeGomez Rollup of 9 pull requests Successful merges: - rust-lang#112034 (Migrate `item_opaque_ty` to Askama) - rust-lang#112179 (Avoid passing --cpu-features when empty) - rust-lang#112309 (bootstrap: remove dependency `is-terminal`) - rust-lang#112388 (Migrate GUI colors test to original CSS color format) - rust-lang#112389 (Add a test for rust-lang#105709) - rust-lang#112392 (Fix ICE for while loop with assignment condition with LHS place expr) - rust-lang#112394 (Remove accidental comment) - rust-lang#112396 (Track more diagnostics in `rustc_expand`) - rust-lang#112401 (Don't `use compile_error as print`) r? `@ghost` `@rustbot` modify labels: rollup
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates
item_opaque_tyto AskamaRefers: #108868