nop_lift macros: ensure that we are using the right interner #115907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @oli-obk (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
RalfJung
force-pushed
the
interner-check
branch
from
cd28b96 to
3b817b2
Compare
|
@bors r=compiler-errors |
bors
added
S-waiting-on-bors
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Sep 18, 2023
…r-errors nop_lift macros: ensure that we are using the right interner Right now someone could put down the wrong list name when using these macros, and everything would still build. Nothing does a type-check to ensure that the `$set` contains element of type `Self::Lifted`. Let's fix that. For lists this is fairly easy; for the other interners we need to unwrap some newtypes which makes this more complicated.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Sep 18, 2023
…r-errors nop_lift macros: ensure that we are using the right interner Right now someone could put down the wrong list name when using these macros, and everything would still build. Nothing does a type-check to ensure that the `$set` contains element of type `Self::Lifted`. Let's fix that. For lists this is fairly easy; for the other interners we need to unwrap some newtypes which makes this more complicated.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 18, 2023
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#115558 (issue has since been fixed) - rust-lang#115724 (Add myself to the mailmap) - rust-lang#115795 (Refactor `opt-dist` to simplify local building) - rust-lang#115811 (Make AIX known by bootstrap) - rust-lang#115838 (inspect: closer to proof trees for coherence) - rust-lang#115902 (Fix up a few CI images) - rust-lang#115907 (nop_lift macros: ensure that we are using the right interner) - rust-lang#115916 (Add me as on vacation) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 18, 2023
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#115558 (issue has since been fixed) - rust-lang#115724 (Add myself to the mailmap) - rust-lang#115811 (Make AIX known by bootstrap) - rust-lang#115838 (inspect: closer to proof trees for coherence) - rust-lang#115902 (Fix up a few CI images) - rust-lang#115907 (nop_lift macros: ensure that we are using the right interner) - rust-lang#115908 (Do not clone MIR for const-prop lint.) - rust-lang#115916 (Add me as on vacation) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 18, 2023
Rollup merge of rust-lang#115907 - RalfJung:interner-check, r=compiler-errors nop_lift macros: ensure that we are using the right interner Right now someone could put down the wrong list name when using these macros, and everything would still build. Nothing does a type-check to ensure that the `$set` contains element of type `Self::Lifted`. Let's fix that. For lists this is fairly easy; for the other interners we need to unwrap some newtypes which makes this more complicated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now someone could put down the wrong list name when using these macros, and everything would still build. Nothing does a type-check to ensure that the
$setcontains element of typeSelf::Lifted. Let's fix that.For lists this is fairly easy; for the other interners we need to unwrap some newtypes which makes this more complicated.