Include arguments to the precondition check in failure messages #134938

saethlin · 2024-12-30T21:19:17Z

Trying to format the types we want using the built-in Display/Debug impls creates a lot of calls from compiler-builtins to core.

My solution for that is to provide a different Display impl though a wrapper type. It is easy to make the entire implementation to get monomorphized in compiler-builtins, which is some serious hoop-jumping because #122580 patches our call to panic_nounwind_fmt during codegen to just llvm.trap. So we're actually just making sure that dead code can't cause a linker error.

saethlin · 2024-12-30T21:19:27Z

@bors try @rust-timer queue

…r=<try> Include arguments to the precondition check in failure messages For now, just checking if this tanks compile times or something like that. It shouldn't? I hope? r? ghost

bors · 2024-12-30T21:20:37Z

⌛ Trying commit 65e5e12 with merge 3e5570d...

bors · 2024-12-30T23:07:47Z

☀️ Try build successful - checks-actions
Build commit: 3e5570d (3e5570d97bbdc7ad24c94a33f53de28891b51c2f)

rust-timer · 2024-12-31T00:23:05Z

Finished benchmarking commit (3e5570d): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	0.6%	[0.2%, 1.2%]	13
Regressions ❌ (secondary)	0.7%	[0.3%, 1.2%]	5
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.3%	[-0.4%, -0.2%]	2
All ❌✅ (primary)	0.6%	[0.2%, 1.2%]	13

Max RSS (memory usage)

Results (primary 0.2%, secondary 2.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.3%	[1.0%, 6.9%]	5
Regressions ❌ (secondary)	2.2%	[0.7%, 3.7%]	3
Improvements ✅ (primary)	-3.7%	[-6.8%, -1.8%]	4
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.2%	[-6.8%, 6.9%]	9

Cycles

Results (primary 1.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.5%	[1.5%, 1.5%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.5%	[1.5%, 1.5%]	1

Binary size

Results (primary 0.4%, secondary 1.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.5%	[0.1%, 4.2%]	67
Regressions ❌ (secondary)	1.5%	[0.3%, 7.0%]	7
Improvements ✅ (primary)	-0.3%	[-0.4%, -0.0%]	9
Improvements ✅ (secondary)	-0.2%	[-0.2%, -0.2%]	3
All ❌✅ (primary)	0.4%	[-0.4%, 4.2%]	76

Bootstrap: 759.925s -> 762.008s (0.27%)
Artifact size: 325.47 MiB -> 325.53 MiB (0.02%)

saethlin · 2024-12-31T00:25:17Z

The most-regressed benchmark jumped from 2 CGUs to 4 CGUs. I wonder if that means that the overhead here is coming from having both macros in the codebase.

saethlin · 2024-12-31T05:00:17Z

@bors try @rust-timer queue

…r=<try> Include arguments to the precondition check in failure messages For now, just checking if this tanks compile times or something like that. It shouldn't? I hope? r? ghost

bors · 2024-12-31T05:01:28Z

⌛ Trying commit 4dc2e6c with merge ab6d099...

bors · 2024-12-31T06:49:19Z

☀️ Try build successful - checks-actions
Build commit: ab6d099 (ab6d099e757160119c73b5a102cc1bc7a5dae9ca)

rust-timer · 2024-12-31T08:21:38Z

Finished benchmarking commit (ab6d099): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	0.7%	[0.2%, 2.2%]	26
Regressions ❌ (secondary)	3.1%	[0.1%, 12.0%]	40
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.4%	[-1.5%, -0.2%]	10
All ❌✅ (primary)	0.7%	[0.2%, 2.2%]	26

Max RSS (memory usage)

Results (primary -2.2%, secondary 2.6%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.8%	[2.0%, 3.2%]	3
Regressions ❌ (secondary)	3.0%	[1.2%, 5.0%]	21
Improvements ✅ (primary)	-4.1%	[-8.1%, -1.0%]	8
Improvements ✅ (secondary)	-1.8%	[-2.4%, -1.3%]	2
All ❌✅ (primary)	-2.2%	[-8.1%, 3.2%]	11

Cycles

Results (primary 1.8%, secondary 4.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.8%	[1.2%, 2.4%]	3
Regressions ❌ (secondary)	4.7%	[2.4%, 12.1%]	21
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.6%	[-1.6%, -1.6%]	1
All ❌✅ (primary)	1.8%	[1.2%, 2.4%]	3

Binary size

Results (primary 1.0%, secondary 1.8%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.1%	[0.0%, 7.1%]	69
Regressions ❌ (secondary)	1.9%	[0.0%, 4.7%]	32
Improvements ✅ (primary)	-0.3%	[-0.6%, -0.2%]	7
Improvements ✅ (secondary)	-0.1%	[-0.1%, -0.1%]	3
All ❌✅ (primary)	1.0%	[-0.6%, 7.1%]	76

Bootstrap: 761.022s -> 762.055s (0.14%)
Artifact size: 325.49 MiB -> 325.53 MiB (0.01%)

bors · 2025-02-18T21:47:26Z

☔ The latest upstream changes (presumably #137231) made this pull request unmergeable. Please resolve the merge conflicts.

Include arguments to the precondition check in failure messages

rust-bors · 2025-10-12T08:21:07Z

☀️ Try build successful (CI)
Build commit: 627939d (627939dc7a6f8ba7aea6d3ebd14d32f3d647fda6, parent: 3be68033b67dfc2aa3ae4cfe735aa5805aebae43)

rust-timer · 2025-10-12T09:31:15Z

Finished benchmarking commit (627939d): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.8%	[0.1%, 4.1%]	42
Regressions ❌ (secondary)	2.3%	[0.1%, 15.4%]	50
Improvements ✅ (primary)	-1.1%	[-2.1%, -0.2%]	2
Improvements ✅ (secondary)	-0.5%	[-2.0%, -0.1%]	16
All ❌✅ (primary)	0.7%	[-2.1%, 4.1%]	44

Max RSS (memory usage)

Results (primary 1.2%, secondary 3.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.4%	[0.6%, 5.2%]	10
Regressions ❌ (secondary)	3.7%	[0.7%, 6.9%]	25
Improvements ✅ (primary)	-3.0%	[-4.8%, -1.7%]	3
Improvements ✅ (secondary)	-1.7%	[-2.4%, -0.7%]	3
All ❌✅ (primary)	1.2%	[-4.8%, 5.2%]	13

Cycles

Results (primary 3.4%, secondary 3.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	3.4%	[2.2%, 5.3%]	4
Regressions ❌ (secondary)	5.6%	[1.3%, 14.9%]	19
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.9%	[-4.1%, -1.9%]	5
All ❌✅ (primary)	3.4%	[2.2%, 5.3%]	4

Binary size

Results (primary 1.0%, secondary 1.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.4%	[0.0%, 7.2%]	65
Regressions ❌ (secondary)	4.1%	[0.0%, 15.0%]	39
Improvements ✅ (primary)	-0.1%	[-0.1%, -0.0%]	26
Improvements ✅ (secondary)	-0.3%	[-6.0%, -0.0%]	40
All ❌✅ (primary)	1.0%	[-0.1%, 7.2%]	91

Bootstrap: 472.207s -> 470.849s (-0.29%)
Artifact size: 388.10 MiB -> 388.57 MiB (0.12%)

saethlin · 2025-10-12T15:37:15Z

@bors try @rust-timer queue

Include arguments to the precondition check in failure messages

rust-bors · 2025-10-12T17:52:28Z

☀️ Try build successful (CI)
Build commit: fbea472 (fbea47299a56e5e3df33db540b2a6b4086f171fd, parent: 89276493d3c3f85691e76b27a9dde7ec82e79cdb)

rust-timer · 2025-10-12T19:03:25Z

Finished benchmarking commit (fbea472): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.6%	[0.2%, 3.4%]	39
Regressions ❌ (secondary)	1.5%	[0.1%, 8.5%]	45
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.4%	[-2.6%, -0.1%]	15
All ❌✅ (primary)	0.6%	[0.2%, 3.4%]	39

Max RSS (memory usage)

Results (primary 2.5%, secondary 3.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.8%	[0.5%, 11.0%]	13
Regressions ❌ (secondary)	3.8%	[1.5%, 6.9%]	26
Improvements ✅ (primary)	-1.5%	[-1.5%, -1.5%]	1
Improvements ✅ (secondary)	-1.1%	[-1.5%, -0.9%]	3
All ❌✅ (primary)	2.5%	[-1.5%, 11.0%]	14

Cycles

Results (primary 2.8%, secondary 2.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.8%	[2.1%, 3.6%]	8
Regressions ❌ (secondary)	4.2%	[1.1%, 8.7%]	17
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.8%	[-6.2%, -2.1%]	5
All ❌✅ (primary)	2.8%	[2.1%, 3.6%]	8

Binary size

Results (primary 0.7%, secondary 1.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.1%	[0.0%, 7.1%]	65
Regressions ❌ (secondary)	2.0%	[0.0%, 7.1%]	40
Improvements ✅ (primary)	-0.1%	[-0.4%, -0.0%]	25
Improvements ✅ (secondary)	-0.1%	[-2.5%, -0.0%]	39
All ❌✅ (primary)	0.7%	[-0.4%, 7.1%]	90

Bootstrap: 471.9s -> 474.695s (0.59%)
Artifact size: 388.11 MiB -> 388.57 MiB (0.12%)

saethlin · 2025-10-13T00:18:38Z

@bors try @rust-timer queue

Include arguments to the precondition check in failure messages

rust-log-analyzer · 2025-10-13T01:24:42Z

The job x86_64-gnu-miri failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

tests/fail/tree_borrows/reserved/int-protected-write.rs ... ok
tests/fail/tree_borrows/reserved/cell-protected-write.rs ... ok

FAILED TEST: tests/fail/ptr_swap_nonoverlapping.rs
command: MIRI_ENV_VAR_TEST="0" MIRI_TEMP="/tmp/miri-uitest-VMfL79" RUST_BACKTRACE="1" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/miri" "--error-format=json" "--sysroot=/checkout/obj/build/x86_64-unknown-linux-gnu/miri-sysroot" "-Dwarnings" "-Dunused" "-Ainternal_features" "-Zui-testing" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/tmp/miri_ui/0/tests/fail" "tests/fail/ptr_swap_nonoverlapping.rs" "--edition" "2021" "--target" "i686-pc-windows-msvc"

error: actual output differed from expected
Execute `./miri test --bless` to update `tests/fail/ptr_swap_nonoverlapping.stderr` to the actual output
--- tests/fail/ptr_swap_nonoverlapping.stderr
+++ <stderr output>
 
 thread 'main' ($TID) panicked at RUSTLIB/core/src/ptr/mod.rs:LL:CC:
-ptr::swap_nonoverlapping requires that both pointer arguments are aligned and non-null and the specified memory ranges do not overlap (x:$HEX, y:$HEX, size:8, align:8, count:1)
+ptr::swap_nonoverlapping requires that both pointer arguments are aligned and non-null and the specified memory ranges do not overlap (x:$HEX, y:$HEX, size:4, align:4, count:1)
 note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
 note: in Miri, you may have to set `MIRIFLAGS=-Zmiri-env-forward=RUST_BACKTRACE` for the environment variable to have an effect
... 21 lines skipped ...
 error: aborting due to 1 previous error
 

Full unnormalized output:

thread 'main' (1) panicked at /checkout/library/core/src/ptr/mod.rs:1395:5:
ptr::swap_nonoverlapping requires that both pointer arguments are aligned and non-null and the specified memory ranges do not overlap (x:0x20818, y:0x20818, size:4, align:4, count:1)
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
note: in Miri, you may have to set `MIRIFLAGS=-Zmiri-env-forward=RUST_BACKTRACE` for the environment variable to have an effect
thread caused non-unwinding panic. aborting.
error: abnormal termination: the program aborted execution
##[error]  --> /checkout/library/std/src/panicking.rs:856:9
   |
LL |         crate::process::abort();
   |         ^^^^^^^^^^^^^^^^^^^^^^^ abnormal termination occurred here
   |
   = note: BACKTRACE:
   = note: inside `std::panicking::panic_with_hook` at /checkout/library/std/src/panicking.rs:856:9: 856:32
   = note: inside closure at /checkout/library/std/src/panicking.rs:707:13: 712:14
   = note: inside `std::sys::backtrace::__rust_end_short_backtrace::<{closure@std::panicking::panic_handler::{closure#0}}, !>` at /checkout/library/std/src/sys/backtrace.rs:174:18: 174:21
   = note: inside `std::panicking::panic_handler` at /checkout/library/std/src/panicking.rs:698:5: 714:7
   = note: inside `std::ptr::swap_nonoverlapping::precondition_check::runtime` at /checkout/library/core/src/ub_checks.rs:79:25: 79:93
note: inside `main`
  --> tests/fail/ptr_swap_nonoverlapping.rs:11:9
   |
---

full stderr:

thread 'main' (1) panicked at /checkout/library/core/src/ptr/mod.rs:1395:5:
ptr::swap_nonoverlapping requires that both pointer arguments are aligned and non-null and the specified memory ranges do not overlap (x:0x20818, y:0x20818, size:4, align:4, count:1)
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
note: in Miri, you may have to set `MIRIFLAGS=-Zmiri-env-forward=RUST_BACKTRACE` for the environment variable to have an effect
thread caused non-unwinding panic. aborting.
error: abnormal termination: the program aborted execution
##[error]  --> /checkout/library/std/src/panicking.rs:856:9
   |
LL |         crate::process::abort();
   |         ^^^^^^^^^^^^^^^^^^^^^^^ abnormal termination occurred here
   |
   = note: BACKTRACE:
   = note: inside `std::panicking::panic_with_hook` at /checkout/library/std/src/panicking.rs:856:9: 856:32
   = note: inside closure at /checkout/library/std/src/panicking.rs:707:13: 712:14
   = note: inside `std::sys::backtrace::__rust_end_short_backtrace::<{closure@std::panicking::panic_handler::{closure#0}}, !>` at /checkout/library/std/src/sys/backtrace.rs:174:18: 174:21
   = note: inside `std::panicking::panic_handler` at /checkout/library/std/src/panicking.rs:698:5: 714:7
   = note: inside `std::ptr::swap_nonoverlapping::precondition_check::runtime` at /checkout/library/core/src/ub_checks.rs:79:25: 79:93
note: inside `main`
  --> tests/fail/ptr_swap_nonoverlapping.rs:11:9
   |
---
Location:
   /cargo/registry/src/index.crates.io-1949cf8c6b5b557f/ui_test-0.30.2/src/lib.rs:365

  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ BACKTRACE ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
   1: <color_eyre[5d21858cef31c5c4]::config::EyreHook>::into_eyre_hook::{closure#0}<unknown>
      at <unknown source file>:<unknown line>
   2: <eyre[bbd5fc24be105606]::Report>::from_adhoc::<&str><unknown>
      at <unknown source file>:<unknown line>
   3: ui_test[55d4203eb6c3de68]::run_tests_generic::<ui_test[55d4203eb6c3de68]::default_file_filter, ui[4de1d89450b99a3c]::run_tests::{closure#1}, alloc[9ee24a5f590ff990]::boxed::Box<dyn ui_test[55d4203eb6c3de68]::status_emitter::StatusEmitter>><unknown>
      at <unknown source file>:<unknown line>
   4: ui[4de1d89450b99a3c]::ui<unknown>
      at <unknown source file>:<unknown line>
   5: ui[4de1d89450b99a3c]::main<unknown>
      at <unknown source file>:<unknown line>
   6: std[ac44c38bb586283e]::sys::backtrace::__rust_begin_short_backtrace::<fn() -> core[c99e2b7a12df8cf9]::result::Result<(), eyre[bbd5fc24be105606]::Report>, core[c99e2b7a12df8cf9]::result::Result<(), eyre[bbd5fc24be105606]::Report>><unknown>
      at <unknown source file>:<unknown line>
   7: std[ac44c38bb586283e]::rt::lang_start::<core[c99e2b7a12df8cf9]::result::Result<(), eyre[bbd5fc24be105606]::Report>>::{closure#0}<unknown>
      at <unknown source file>:<unknown line>
   8: std[ac44c38bb586283e]::rt::lang_start_internal<unknown>
      at <unknown source file>:<unknown line>
   9: main<unknown>
      at <unknown source file>:<unknown line>
  10: __libc_start_main<unknown>
      at <unknown source file>:<unknown line>
  11: _start<unknown>
      at <unknown source file>:<unknown line>

Run with COLORBT_SHOW_HIDDEN=1 environment variable to disable frame filtering.
Run with RUST_BACKTRACE=full to include source snippets.
error: test failed, to rerun pass `--test ui`

Caused by:
  process didn't exit successfully: `/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/ui-eca9d5916b357dc3` (exit status: 1)
Bootstrap failed while executing `test --stage 2 src/tools/miri src/tools/miri/cargo-miri --target i686-pc-windows-msvc`
Command `/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo test --target x86_64-unknown-linux-gnu -Zbinary-dep-depinfo -j 4 -Zroot-dir=/checkout --locked --color always --release --manifest-path /checkout/src/tools/miri/Cargo.toml -- [workdir=/checkout]` failed with exit code 1
Created at: src/bootstrap/src/core/build_steps/tool.rs:191:21
Executed at: src/bootstrap/src/core/build_steps/test.rs:677:19

Command has failed. Rerun with -v to see more details.
Build completed unsuccessfully in 0:02:40
  local time: Mon Oct 13 01:24:30 UTC 2025
  network time: Mon, 13 Oct 2025 01:24:30 GMT
##[error]Process completed with exit code 1.
Post job cleanup.

rust-bors · 2025-10-13T02:31:17Z

☀️ Try build successful (CI)
Build commit: c7fe794 (c7fe7941f204ae9bbe7557707916ff3505bc34a7, parent: 2300c2aef7dbc2a7bbbeaa9894d07d459abd9bc6)

rust-timer · 2025-10-13T04:49:53Z

Finished benchmarking commit (c7fe794): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.7%	[0.2%, 3.4%]	35
Regressions ❌ (secondary)	1.6%	[0.1%, 8.8%]	46
Improvements ✅ (primary)	-0.5%	[-0.5%, -0.5%]	1
Improvements ✅ (secondary)	-0.4%	[-2.4%, -0.0%]	15
All ❌✅ (primary)	0.7%	[-0.5%, 3.4%]	36

Max RSS (memory usage)

Results (primary 0.8%, secondary 4.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.5%	[0.5%, 7.3%]	8
Regressions ❌ (secondary)	4.3%	[0.9%, 7.0%]	19
Improvements ✅ (primary)	-5.9%	[-9.2%, -2.5%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.8%	[-9.2%, 7.3%]	10

Cycles

Results (primary 3.0%, secondary 2.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	3.0%	[2.2%, 4.7%]	4
Regressions ❌ (secondary)	3.8%	[1.6%, 9.2%]	22
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.2%	[-4.2%, -2.2%]	4
All ❌✅ (primary)	3.0%	[2.2%, 4.7%]	4

Binary size

Results (primary 0.7%, secondary 1.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.1%	[0.0%, 7.3%]	65
Regressions ❌ (secondary)	2.2%	[0.0%, 7.3%]	40
Improvements ✅ (primary)	-0.1%	[-0.5%, -0.0%]	31
Improvements ✅ (secondary)	-0.1%	[-2.6%, -0.0%]	39
All ❌✅ (primary)	0.7%	[-0.5%, 7.3%]	96

Bootstrap: 472.507s -> 472.273s (-0.05%)
Artifact size: 388.12 MiB -> 388.15 MiB (0.01%)

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 30, 2024