Skip to content

trait_sel: MetaSized always holds temporarily #144016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 17, 2025
Merged

trait_sel: MetaSized always holds temporarily #144016

merged 1 commit into from
Jul 17, 2025

Conversation

davidtwco
Copy link
Member

@davidtwco davidtwco commented Jul 16, 2025 •
edited by rustbot
Loading

As a temporary measure while a proper fix for tests/ui/sized-hierarchy/incomplete-inference-issue-143992.rs is implemented, make MetaSized obligations always hold. In effect, temporarily reverting the sized_hierarchy feature. This is a small change that can be backported.

cc #143992
r? @lcnr

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 16, 2025
lcnr
lcnr reviewed Jul 16, 2025
View reviewed changes
@lcnr
Copy link
Contributor

lcnr commented Jul 16, 2025

r=me after CI

@davidtwco
trait_sel: MetaSized always holds temporarily
8d64937 
As a temporary measure while a proper fix for
`tests/ui/sized-hierarchy/incomplete-inference-issue-143992.rs`
is implemented, make `MetaSized` obligations always hold. In effect,
temporarily reverting the `sized_hierarchy` feature. This is a small
change that can be backported.
@davidtwco davidtwco force-pushed the sized-hierarchy-temp-pseudo-revert branch from 3a45f7a to 8d64937 Compare July 16, 2025 12:35
@davidtwco
Copy link
Member Author

CI passed before and all I did was add the revision to the test, which I've confirmed passes locally.

@bors r=lcnr

@bors
Copy link
Collaborator

bors commented Jul 16, 2025

📌 Commit 8d64937 has been approved by lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 16, 2025
@fmease fmease added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jul 16, 2025
fmease added a commit to fmease/rust that referenced this pull request Jul 16, 2025
@fmease
Rollup merge of rust-lang#144016 - davidtwco:sized-hierarchy-temp-pse…
93c4509 
…udo-revert, r=lcnr

trait_sel: `MetaSized` always holds temporarily

As a temporary measure while a proper fix for `tests/ui/sized-hierarchy/incomplete-inference-issue-143992.rs` is implemented, make `MetaSized` obligations always hold. In effect, temporarily reverting the `sized_hierarchy` feature. This is a small change that can be backported.

cc rust-lang#143992
r? ``@lcnr``
@fmease fmease mentioned this pull request Jul 16, 2025
Closed
bors added a commit that referenced this pull request Jul 17, 2025
@bors
Auto merge of #144041 - fmease:rollup-spzdlyz, r=fmease
c0f46ce 
Rollup of 15 pull requests

Successful merges:

 - #142304 (tests: Add `RUST_BACKTRACE` and `-Cpanic` revisions to `panic-main.rs` test)
 - #143388 (Various refactors to the LTO handling code)
 - #143409 (Enable xgot feature for mips64 musl targets)
 - #143592 (UWP: link ntdll functions using raw-dylib)
 - #143595 (add `const_make_global`; err for `const_allocate` ptrs if didn't call)
 - #143678 (Added error for invalid char cast)
 - #143820 (Fixed a core crate compilation failure when enabling the `optimize_for_size` feature on some targets)
 - #143829 (Trim `BorrowedCursor` API)
 - #143846 (pass --gc-sections if -Zexport-executable-symbols is enabled and improve tests)
 - #143851 (ci cleanup: rustdoc-gui-test now installs browser-ui-test)
 - #143856 (Linting public reexport of private dependencies)
 - #143895 (Dont collect assoc ty item bounds from trait where clause for host effect predicates)
 - #143922 (Improve path segment joining)
 - #143964 (Fix handling of SCRIPT_ARG in docker images)
 - #144016 (trait_sel: `MetaSized` always holds temporarily)

r? `@ghost`
`@rustbot` modify labels: rollup
@fmease fmease mentioned this pull request Jul 17, 2025
Merged
bors added a commit that referenced this pull request Jul 17, 2025
@bors
Auto merge of #144044 - fmease:rollup-kg413pt, r=fmease
f8f6997 
Rollup of 15 pull requests

Successful merges:

 - #142304 (tests: Add `RUST_BACKTRACE` and `-Cpanic` revisions to `panic-main.rs` test)
 - #143388 (Various refactors to the LTO handling code)
 - #143409 (Enable xgot feature for mips64 musl targets)
 - #143592 (UWP: link ntdll functions using raw-dylib)
 - #143595 (add `const_make_global`; err for `const_allocate` ptrs if didn't call)
 - #143678 (Added error for invalid char cast)
 - #143820 (Fixed a core crate compilation failure when enabling the `optimize_for_size` feature on some targets)
 - #143829 (Trim `BorrowedCursor` API)
 - #143851 (ci cleanup: rustdoc-gui-test now installs browser-ui-test)
 - #143856 (Linting public reexport of private dependencies)
 - #143895 (Dont collect assoc ty item bounds from trait where clause for host effect predicates)
 - #143922 (Improve path segment joining)
 - #143964 (Fix handling of SCRIPT_ARG in docker images)
 - #144002 (Update poison.rs)
 - #144016 (trait_sel: `MetaSized` always holds temporarily)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d5a471c into rust-lang:master Jul 17, 2025
11 checks passed
rust-timer added a commit that referenced this pull request Jul 17, 2025
@rust-timer
Unrolled build for #144016
b838d9c 
Rollup merge of #144016 - davidtwco:sized-hierarchy-temp-pseudo-revert, r=lcnr

trait_sel: `MetaSized` always holds temporarily

As a temporary measure while a proper fix for `tests/ui/sized-hierarchy/incomplete-inference-issue-143992.rs` is implemented, make `MetaSized` obligations always hold. In effect, temporarily reverting the `sized_hierarchy` feature. This is a small change that can be backported.

cc #143992
r? ```@lcnr```
@rustbot rustbot added this to the 1.90.0 milestone Jul 17, 2025
@davidtwco davidtwco deleted the sized-hierarchy-temp-pseudo-revert branch July 17, 2025 09:17
davidtwco added a commit to davidtwco/rust that referenced this pull request Jul 17, 2025
@davidtwco
revert: rust-lang#144016 - MetaSized does not always hold
f053d9e
@davidtwco davidtwco mentioned this pull request Jul 17, 2025
Merged
@lcnr lcnr mentioned this pull request Jul 17, 2025
Closed
@apiraino
Copy link
Contributor

Beta backport accepted as per compiler team on Zulip. A backport PR will be authored by the release team at the end of the current development cycle. Backport labels handled by them.

@rustbot label +beta-accepted

@rustbot rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jul 17, 2025
@cuviper cuviper mentioned this pull request Jul 17, 2025
Merged
@cuviper cuviper modified the milestones: 1.90.0, 1.89.0 Jul 17, 2025
@cuviper cuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jul 17, 2025
bors added a commit that referenced this pull request Jul 21, 2025
@bors
Auto merge of #144087 - cuviper:beta-next, r=cuviper
7c39f45 
[beta] backports

- Taint body on invalid call ABI #142983
- Fix rustdoc not correctly showing attributes with re-exports #143083
- trait_sel: `MetaSized` always holds temporarily #144016

r? cuviper
bors added a commit that referenced this pull request Jul 21, 2025
@bors
Auto merge of #144087 - cuviper:beta-next, r=cuviper
2589502 
[beta] backports

- Taint body on invalid call ABI #142983
- Fix rustdoc not correctly showing attributes with re-exports #143083
- trait_sel: `MetaSized` always holds temporarily #144016

r? cuviper
bors added a commit that referenced this pull request Jul 21, 2025
@bors
Auto merge of #144087 - cuviper:beta-next, r=cuviper
20c571f 
[beta] backports

- Taint body on invalid call ABI #142983
- Fix rustdoc not correctly showing attributes with re-exports #143083
- trait_sel: `MetaSized` always holds temporarily #144016
- Ensure home directory exists #144003

r? cuviper
Muscraft pushed a commit to Muscraft/rust that referenced this pull request Jul 21, 2025
@fmease @Muscraft
Rollup merge of rust-lang#144016 - davidtwco:sized-hierarchy-temp-pse…
d0b31a1 
…udo-revert, r=lcnr

trait_sel: `MetaSized` always holds temporarily

As a temporary measure while a proper fix for `tests/ui/sized-hierarchy/incomplete-inference-issue-143992.rs` is implemented, make `MetaSized` obligations always hold. In effect, temporarily reverting the `sized_hierarchy` feature. This is a small change that can be backported.

cc rust-lang#143992
r? ```@lcnr```
Muscraft pushed a commit to Muscraft/rust that referenced this pull request Jul 21, 2025
@bors @Muscraft
Auto merge of rust-lang#144044 - fmease:rollup-kg413pt, r=fmease
e3e96c8 
Rollup of 15 pull requests

Successful merges:

 - rust-lang#142304 (tests: Add `RUST_BACKTRACE` and `-Cpanic` revisions to `panic-main.rs` test)
 - rust-lang#143388 (Various refactors to the LTO handling code)
 - rust-lang#143409 (Enable xgot feature for mips64 musl targets)
 - rust-lang#143592 (UWP: link ntdll functions using raw-dylib)
 - rust-lang#143595 (add `const_make_global`; err for `const_allocate` ptrs if didn't call)
 - rust-lang#143678 (Added error for invalid char cast)
 - rust-lang#143820 (Fixed a core crate compilation failure when enabling the `optimize_for_size` feature on some targets)
 - rust-lang#143829 (Trim `BorrowedCursor` API)
 - rust-lang#143851 (ci cleanup: rustdoc-gui-test now installs browser-ui-test)
 - rust-lang#143856 (Linting public reexport of private dependencies)
 - rust-lang#143895 (Dont collect assoc ty item bounds from trait where clause for host effect predicates)
 - rust-lang#143922 (Improve path segment joining)
 - rust-lang#143964 (Fix handling of SCRIPT_ARG in docker images)
 - rust-lang#144002 (Update poison.rs)
 - rust-lang#144016 (trait_sel: `MetaSized` always holds temporarily)

r? `@ghost`
`@rustbot` modify labels: rollup
@davidtwco davidtwco mentioned this pull request Jul 24, 2025
Open
13 tasks
rust-cloud-vms bot pushed a commit to makai410/rustc_public that referenced this pull request Aug 16, 2025
@bors
Auto merge of #144044 - fmease:rollup-kg413pt, r=fmease
fd6d086 
Rollup of 15 pull requests

Successful merges:

 - rust-lang/rust#142304 (tests: Add `RUST_BACKTRACE` and `-Cpanic` revisions to `panic-main.rs` test)
 - rust-lang/rust#143388 (Various refactors to the LTO handling code)
 - rust-lang/rust#143409 (Enable xgot feature for mips64 musl targets)
 - rust-lang/rust#143592 (UWP: link ntdll functions using raw-dylib)
 - rust-lang/rust#143595 (add `const_make_global`; err for `const_allocate` ptrs if didn't call)
 - rust-lang/rust#143678 (Added error for invalid char cast)
 - rust-lang/rust#143820 (Fixed a core crate compilation failure when enabling the `optimize_for_size` feature on some targets)
 - rust-lang/rust#143829 (Trim `BorrowedCursor` API)
 - rust-lang/rust#143851 (ci cleanup: rustdoc-gui-test now installs browser-ui-test)
 - rust-lang/rust#143856 (Linting public reexport of private dependencies)
 - rust-lang/rust#143895 (Dont collect assoc ty item bounds from trait where clause for host effect predicates)
 - rust-lang/rust#143922 (Improve path segment joining)
 - rust-lang/rust#143964 (Fix handling of SCRIPT_ARG in docker images)
 - rust-lang/rust#144002 (Update poison.rs)
 - rust-lang/rust#144016 (trait_sel: `MetaSized` always holds temporarily)

r? `@ghost`
`@rustbot` modify labels: rollup
rust-cloud-vms bot pushed a commit to makai410/rustc_public that referenced this pull request Aug 20, 2025
@bors
Auto merge of #144044 - fmease:rollup-kg413pt, r=fmease
f585733 
Rollup of 15 pull requests

Successful merges:

 - rust-lang/rust#142304 (tests: Add `RUST_BACKTRACE` and `-Cpanic` revisions to `panic-main.rs` test)
 - rust-lang/rust#143388 (Various refactors to the LTO handling code)
 - rust-lang/rust#143409 (Enable xgot feature for mips64 musl targets)
 - rust-lang/rust#143592 (UWP: link ntdll functions using raw-dylib)
 - rust-lang/rust#143595 (add `const_make_global`; err for `const_allocate` ptrs if didn't call)
 - rust-lang/rust#143678 (Added error for invalid char cast)
 - rust-lang/rust#143820 (Fixed a core crate compilation failure when enabling the `optimize_for_size` feature on some targets)
 - rust-lang/rust#143829 (Trim `BorrowedCursor` API)
 - rust-lang/rust#143851 (ci cleanup: rustdoc-gui-test now installs browser-ui-test)
 - rust-lang/rust#143856 (Linting public reexport of private dependencies)
 - rust-lang/rust#143895 (Dont collect assoc ty item bounds from trait where clause for host effect predicates)
 - rust-lang/rust#143922 (Improve path segment joining)
 - rust-lang/rust#143964 (Fix handling of SCRIPT_ARG in docker images)
 - rust-lang/rust#144002 (Update poison.rs)
 - rust-lang/rust#144016 (trait_sel: `MetaSized` always holds temporarily)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Oct 15, 2025
@bors
Auto merge of #144064 - davidtwco:prefer-alias-over-env-for-sizedness…
27c2465 
…, r=lcnr

prefer alias candidates for sizedness + auto trait goals

Fixes #143992

- abd07de: Reverts #144016 so that `MetaSized` bounds are checked properly, and updates all the tests accordingly, including making `tests/ui/sized-hierarchy/incomplete-inference-issue-143992.rs` fail when it shouldn't
- 90e61db: Prefer alias candidates over parameter environment candidates for sizedness, auto and default traits. `tests/ui/sized-hierarchy/incomplete-inference-issue-143992.rs` passes again, but `tests/ui/generic-associated-types/issue-93262.rs` starts failing when it shouldn't
- e412062: No longer require that predicates of aliases hold in well-formedness checking of the alias. `tests/ui/generic-associated-types/issue-93262.rs` passes again

Each commit updates all the tests to their new output so it should be easy enough to see what the impact of each change individually is. After all of the changes, tests that pass when they didn't before or vice versa:

- `tests/ui/extern/extern-types-size_of_val.rs`
    - Previously passing, but only because of #144016, now correctly errors
- `tests/ui/sized-hierarchy/incomplete-inference-issue-143992.rs`
    - Previously failing on next solver, only because #144016 only applied to the old solver, passing now with 90e61db
- `tests/ui/sized-hierarchy/overflow.rs`
    - Previously passing, but only because of #144016, now correctly errors
- `tests/ui/generic-associated-types/issue-92096.rs`
    - Previously passing, due to e412062
    - Fails to prove `C::Connecting<'placeholder>: Send` which is required when proving that the generator is `Send`. This is an instance of #110338.
- `tests/ui/higher-ranked/trait-bounds/normalize-under-binder/norm-before-method-resolution-opaque-type.rs`
    - Previously passing, now failing in the next solver, due to 03e0fda
    - Expected that this test now fails as ambigious, see [Zulip](https://rust-lang.zulipchat.com/#narrow/channel/144729-t-types/topic/sizedness.20bounds.20in.20explicit_implied_predicates_of.20.28.23142712.29/near/526987384)

This had a crater run in #142712 (comment) alongside some other changes.

r? `@lcnr`
cc #142712 (this extracts part of that change)
bors added a commit that referenced this pull request Oct 15, 2025
@bors
Auto merge of #144064 - davidtwco:prefer-alias-over-env-for-sizedness…
57ef8d6 
…, r=lcnr

prefer alias candidates for sizedness + auto trait goals

Fixes #143992

- abd07de: Reverts #144016 so that `MetaSized` bounds are checked properly, and updates all the tests accordingly, including making `tests/ui/sized-hierarchy/incomplete-inference-issue-143992.rs` fail when it shouldn't
- 90e61db: Prefer alias candidates over parameter environment candidates for sizedness, auto and default traits. `tests/ui/sized-hierarchy/incomplete-inference-issue-143992.rs` passes again, but `tests/ui/generic-associated-types/issue-93262.rs` starts failing when it shouldn't
- e412062: No longer require that predicates of aliases hold in well-formedness checking of the alias. `tests/ui/generic-associated-types/issue-93262.rs` passes again

Each commit updates all the tests to their new output so it should be easy enough to see what the impact of each change individually is. After all of the changes, tests that pass when they didn't before or vice versa:

- `tests/ui/extern/extern-types-size_of_val.rs`
    - Previously passing, but only because of #144016, now correctly errors
- `tests/ui/sized-hierarchy/incomplete-inference-issue-143992.rs`
    - Previously failing on next solver, only because #144016 only applied to the old solver, passing now with 90e61db
- `tests/ui/sized-hierarchy/overflow.rs`
    - Previously passing, but only because of #144016, now correctly errors
- `tests/ui/generic-associated-types/issue-92096.rs`
    - Previously passing, due to e412062
    - Fails to prove `C::Connecting<'placeholder>: Send` which is required when proving that the generator is `Send`. This is an instance of #110338.
- `tests/ui/higher-ranked/trait-bounds/normalize-under-binder/norm-before-method-resolution-opaque-type.rs`
    - Previously passing, now failing in the next solver, due to 03e0fda
    - Expected that this test now fails as ambigious, see [Zulip](https://rust-lang.zulipchat.com/#narrow/channel/144729-t-types/topic/sizedness.20bounds.20in.20explicit_implied_predicates_of.20.28.23142712.29/near/526987384)

This had a crater run in #142712 (comment) alongside some other changes.

r? `@lcnr`
cc #142712 (this extracts part of that change)
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Oct 16, 2025
@bors
Auto merge of #144064 - davidtwco:prefer-alias-over-env-for-sizedness…
44c9af8 
…, r=lcnr

prefer alias candidates for sizedness + auto trait goals

Fixes rust-lang/rust#143992

- abd07dec44437554520453f929c2b12d4eb8b11e: Reverts rust-lang/rust#144016 so that `MetaSized` bounds are checked properly, and updates all the tests accordingly, including making `tests/ui/sized-hierarchy/incomplete-inference-issue-143992.rs` fail when it shouldn't
- 90e61db9745f53d9aef21e3ebce0df19cc1389d7: Prefer alias candidates over parameter environment candidates for sizedness, auto and default traits. `tests/ui/sized-hierarchy/incomplete-inference-issue-143992.rs` passes again, but `tests/ui/generic-associated-types/issue-93262.rs` starts failing when it shouldn't
- e412062171925d0b40fdbeb5765c45087bdf0fe7: No longer require that predicates of aliases hold in well-formedness checking of the alias. `tests/ui/generic-associated-types/issue-93262.rs` passes again

Each commit updates all the tests to their new output so it should be easy enough to see what the impact of each change individually is. After all of the changes, tests that pass when they didn't before or vice versa:

- `tests/ui/extern/extern-types-size_of_val.rs`
    - Previously passing, but only because of rust-lang/rust#144016, now correctly errors
- `tests/ui/sized-hierarchy/incomplete-inference-issue-143992.rs`
    - Previously failing on next solver, only because rust-lang/rust#144016 only applied to the old solver, passing now with 90e61db9745f53d9aef21e3ebce0df19cc1389d7
- `tests/ui/sized-hierarchy/overflow.rs`
    - Previously passing, but only because of rust-lang/rust#144016, now correctly errors
- `tests/ui/generic-associated-types/issue-92096.rs`
    - Previously passing, due to e412062171925d0b40fdbeb5765c45087bdf0fe7
    - Fails to prove `C::Connecting<'placeholder>: Send` which is required when proving that the generator is `Send`. This is an instance of rust-lang/rust#110338.
- `tests/ui/higher-ranked/trait-bounds/normalize-under-binder/norm-before-method-resolution-opaque-type.rs`
    - Previously passing, now failing in the next solver, due to 03e0fdab6196e81b44356f42f03b6a0a224cf451
    - Expected that this test now fails as ambigious, see [Zulip](https://rust-lang.zulipchat.com/#narrow/channel/144729-t-types/topic/sizedness.20bounds.20in.20explicit_implied_predicates_of.20.28.23142712.29/near/526987384)

This had a crater run in rust-lang/rust#142712 (comment) alongside some other changes.

r? `@lcnr`
cc rust-lang/rust#142712 (this extracts part of that change)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lcnr lcnr lcnr left review comments

Assignees

@lcnr lcnr

Labels

beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.89.0

Development

Successfully merging this pull request may close these issues.

7 participants

@davidtwco @lcnr @bors @apiraino @cuviper @fmease @rustbot