-
Notifications
You must be signed in to change notification settings - Fork 13.9k
rustdoc: Nuke --passes=list
and defossilize the passes infrastructure
#146529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
rustbot has assigned @GuillaumeGomez. Use |
pub(crate) const CALCULATE_DOC_COVERAGE: Pass = Pass { | ||
name: "calculate-doc-coverage", | ||
run: Some(calculate_doc_coverage), | ||
description: "counts the number of items with and without documentation", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we keep the description as doc-comments?
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
rustdoc: Nuke `--passes=list`
.with_ansi(color_logs) | ||
.with_targets(true) | ||
.with_wraparound(10) | ||
.with_verbose_exit(true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FIXME: nocheckin
--passes=list
--passes=list
and the legacy passes infrastructure
--passes=list
and the legacy passes infrastructure--passes=list
and defossilize the passes infrastructure
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (219856d): comparison URL. Overall result: ✅ improvements - no action neededBenchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf. @bors rollup=never Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResults (primary 2.2%, secondary -0.7%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 469.268s -> 472.628s (0.72%) |
--passes
and--no-defaults
were deprecated and made noops years ago except that--passes list
still prints all passes in a human-readable format as if users could still somehow make use of that information. Removing this useless functionality allows for some small simplifications (and longer term, it would enable us to further rewrite the way we represent internal passes w/o having to worry about it possibly affecting the CLI).Given that the output of
--passes list
is clearly meant for human consumption only (I mean, just look at it), I hold the opinion that this removal doesn't need an FCP. And even if there were scripts somewhere out there that try to parse this output I think it would be okay to break them.