Skip to content

Add regression test for issue #91831 #146622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 18, 2025
Merged

Add regression test for issue #91831 #146622

merged 1 commit into from
Sep 18, 2025

Conversation

aklaiber
Copy link
Contributor

@aklaiber aklaiber commented Sep 16, 2025 •
edited by rustbot
Loading

The requested test for #91831. I'm unsure about the filename, the file structure in tests/ui/lifetimes/lifetime-errors/ isn't entirely clear to me. Any suggestions?

Closes #91831

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 16, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 16, 2025

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot
Copy link
Collaborator

rustbot commented Sep 16, 2025

⚠️ Warning ⚠️

  • There are issue links (such as #123) in the commit messages of the following commits.
    Please move them to the PR description, to avoid spamming the issues with references to the commit, and so this bot can automatically canonicalize them to avoid issues with subtree.

@jdonszelmann
Copy link
Contributor

@aklaiber could you change the commit message to not have the issue number in it (at least not with a # in front of it)?

r=me after that, just ping me and I'll approve

@jdonszelmann
Copy link
Contributor

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 18, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 18, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@aklaiber aklaiber force-pushed the 91831_add_regression_test branch from 114ba83 to 9264673 Compare September 18, 2025 11:57
@aklaiber
Copy link
Contributor Author

@rustbot ready
r? @jdonszelmann

@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Sep 18, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 18, 2025

Requested reviewer is already assigned to this pull request.

Please choose another assignee.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 18, 2025
@jdonszelmann
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Sep 18, 2025

📌 Commit 9264673 has been approved by jdonszelmann

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 18, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 18, 2025
Merged
bors added a commit that referenced this pull request Sep 18, 2025
@bors
Auto merge of #146727 - matthiaskrgr:rollup-98812uj, r=matthiaskrgr
0c0c58b 
Rollup of 6 pull requests

Successful merges:

 - #146434 (c-variadic: allow c-variadic inherent and trait methods)
 - #146487 (Improve `core::num` coverage)
 - #146597 (Add span for struct tail recursion limit error)
 - #146622 (Add regression test for issue #91831)
 - #146717 (Clean up universe evaluation during type test evaluation)
 - #146723 (Include patch in release notes)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f28730f into rust-lang:master Sep 18, 2025
10 checks passed
@rustbot rustbot added this to the 1.92.0 milestone Sep 18, 2025
rust-timer added a commit that referenced this pull request Sep 18, 2025
@rust-timer
Unrolled build for #146622
6eb15dc 
Rollup merge of #146622 - aklaiber:91831_add_regression_test, r=jdonszelmann

Add regression test for issue #91831

The requested test for #91831. I'm unsure about the filename, the file structure in `tests/ui/lifetimes/lifetime-errors/` isn't entirely clear to me. Any suggestions?

Closes #91831
@aklaiber aklaiber deleted the 91831_add_regression_test branch September 19, 2025 04:00
@github-actions github-actions bot mentioned this pull request Sep 22, 2025
Merged
@BenjaminBrienen BenjaminBrienen mentioned this pull request Sep 24, 2025
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jdonszelmann jdonszelmann

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.92.0

Development

Successfully merging this pull request may close these issues.

E0623 gives very confusing message

5 participants

@aklaiber @rustbot @jdonszelmann @bors @fee1-dead