Skip to content

Conversation

brad0
Copy link

@brad0 brad0 commented Sep 25, 2025

No description provided.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 25, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 25, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rust-log-analyzer

This comment has been minimized.

@brad0 brad0 force-pushed the std_detect_openbsd_elf_aux_info branch from 429f929 to 943b406 Compare September 25, 2025 12:45
@Mark-Simulacrum
Copy link
Member

@semarie, could you help review that this is the right way to detect platform features as the relevant target maintainer?

(per https://doc.rust-lang.org/nightly/rustc/platform-support/openbsd.html)

@semarie
Copy link
Contributor

semarie commented Sep 29, 2025

The logic seems good (but not deeply checked for now), but it shouldn't be merged at this stage.

@brad0 could you first look to make elf_aux_info function available for OpenBSD in rust libc ? else, the build will just break due to undefined function.

the steps are:

  • add elf_aux_info(3) in Rust libc
  • hvae it backported to 0.2 branch (should be automatic for such change)
  • have a new release of libc crate with it
  • update rust compiler to use this version of the crate

Once all is done, the PR could be considered.
Thanks.

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 1, 2025
@brad0 brad0 force-pushed the std_detect_openbsd_elf_aux_info branch from 943b406 to 5231fbc Compare October 8, 2025 23:54
@rust-log-analyzer

This comment has been minimized.

@brad0 brad0 force-pushed the std_detect_openbsd_elf_aux_info branch from 5231fbc to 1f6d6fb Compare October 9, 2025 00:06
@brad0
Copy link
Author

brad0 commented Oct 10, 2025

@semarie So the libc part has been completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants