Mention crate being analyzed in query description #147137

estebank · 2025-09-28T23:06:18Z

"running analysis passes on this crate" -> "running analysis passes on crate foo"

This message is displayed in cycle errors in particular, and in some cases without any spans or any other identifiable information to determine which dependency introduced the cycle.

Address #74380, but we still need a test for that case in particular.

rustbot · 2025-09-28T23:06:21Z

This PR modifies tests/ui/issues/. If this PR is adding new tests to tests/ui/issues/,
please refrain from doing so, and instead add it to more descriptive subdirectories.

rustbot · 2025-09-28T23:06:23Z

r? @nnethercote

rustbot has assigned @nnethercote.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

nnethercote · 2025-09-28T23:10:11Z

tests/ui/parallel-rustc/cycle_crash-issue-135870.stderr

 LL | const FOO: usize = FOO;
   |                    ^^^
   = note: ...which again requires simplifying constant for the type system `FOO`, completing the cycle
-   = note: cycle used when running analysis passes on this crate


Why is this line removed?

The rest of the PR looks fine, but this is a worry, because this test looks very similar to the other tests but it is changed in a different way.

An answer here is needed to unblock further progress.

@rustbot author

After rebasing these changes went away.

Your lucky day!

nnethercote · 2025-09-28T23:10:13Z

tests/ui/parallel-rustc/cycle_crash-issue-135870.stderr

 error: aborting due to 1 previous error

-For more information about this error, try `rustc --explain E0391`.
+For more information about this error, try `rustc --explain E0391`.


Why is the file-ending newline removed?

To be perfectly honest: not the faintest idea why my changes affect this test at all 😵

rustbot · 2025-10-13T05:52:23Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

bors · 2025-10-29T03:13:23Z

☔ The latest upstream changes (presumably #148182) made this pull request unmergeable. Please resolve the merge conflicts.

"running analysis passes on this crate" -> "running analysis passes on crate `foo`" This message is displayed in cycle errors in particular, and in some cases without any spans or any other identifiable information to determine which dependency introduced the cycle.

rustbot · 2025-10-31T21:20:18Z

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

nnethercote · 2025-11-01T09:00:27Z

@bors r+ rollup

bors · 2025-11-01T09:00:29Z

📌 Commit 0efeec5 has been approved by nnethercote

It is now in the queue for this repository.

Mention crate being analyzed in query description "running analysis passes on this crate" -> "running analysis passes on crate `foo`" This message is displayed in cycle errors in particular, and in some cases without any spans or any other identifiable information to determine which dependency introduced the cycle. Address rust-lang#74380, but we still need a test for that case in particular.

Rollup of 8 pull requests Successful merges: - #147137 (Mention crate being analyzed in query description) - #148099 (Prepare to move debugger discovery from compiletest to bootstrap) - #148194 (compiletest: Remove `cleanup_debug_info_options`) - #148199 (compiletest: Don't modify `testpaths` when creating aux contexts) - #148240 (rustc_codegen: fix musttail returns for cast/indirect ABIs) - #148247 (Remove two special cases from reachable_non_generics) - #148290 (Do not emit solver errors that contain error types) - #148362 (docs: makes a note about possible building `rustc 1.91.0 + host tools` for win7) r? `@ghost` `@rustbot` modify labels: rollup

Mention crate being analyzed in query description "running analysis passes on this crate" -> "running analysis passes on crate `foo`" This message is displayed in cycle errors in particular, and in some cases without any spans or any other identifiable information to determine which dependency introduced the cycle. Address rust-lang#74380, but we still need a test for that case in particular.

Rollup of 12 pull requests Successful merges: - #147137 (Mention crate being analyzed in query description) - #147642 (Miscellaneous const-generics-related fixes) - #147806 (Ignore test-dashboard related files) - #147947 (Implement `strip_circumfix` lib feature) - #148194 (compiletest: Remove `cleanup_debug_info_options`) - #148199 (compiletest: Don't modify `testpaths` when creating aux contexts) - #148247 (Remove two special cases from reachable_non_generics) - #148348 (dangling ptr lint cleanup) - #148357 (temporary-lifetime-extension.rs test works in all editions) - #148362 (docs: makes a note about possible building `rustc 1.91.0 + host tools` for win7) - #148367 (Use --print host-tuple to get the host) - #148374 (miri subtree update) r? `@ghost` `@rustbot` modify labels: rollup

Mention crate being analyzed in query description "running analysis passes on this crate" -> "running analysis passes on crate `foo`" This message is displayed in cycle errors in particular, and in some cases without any spans or any other identifiable information to determine which dependency introduced the cycle. Address rust-lang#74380, but we still need a test for that case in particular.

Zalathar · 2025-11-02T07:00:38Z

Investigating rollup failure in #148376 (comment):

@bors try jobs=armhf-gnu

rust-bors · 2025-11-02T07:00:42Z

⌛ Trying commit 0efeec5 with merge 950a815…

To cancel the try build, run the command @bors try cancel.

Workflow: https://github.com/rust-lang/rust/actions/runs/19008792157

Mention crate being analyzed in query description try-job: armhf-gnu

Zalathar · 2025-11-02T07:06:17Z

Failure found at #148247 (comment).

@bors try cancel

rust-bors · 2025-11-02T07:06:19Z

Try build cancelled. Cancelled workflows:

https://github.com/rust-lang/rust/actions/runs/19008792157

Rollup of 9 pull requests Successful merges: - #147137 (Mention crate being analyzed in query description) - #147155 (arm-linux.md: various fixes/improvements) - #147642 (Miscellaneous const-generics-related fixes) - #147806 (Ignore test-dashboard related files) - #147947 (Implement `strip_circumfix` lib feature) - #148346 (Change cfg_trace, cfg_attr_trace symbol values) - #148348 (dangling ptr lint cleanup) - #148393 (Remove `tests/run-make/fmt-write-bloat/`) - #148400 (Better warning message for crate type unsupported by codegen backend) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #147137 - estebank:issue-74380, r=nnethercote Mention crate being analyzed in query description "running analysis passes on this crate" -> "running analysis passes on crate `foo`" This message is displayed in cycle errors in particular, and in some cases without any spans or any other identifiable information to determine which dependency introduced the cycle. Address #74380, but we still need a test for that case in particular.

Rollup of 9 pull requests Successful merges: - rust-lang/rust#147137 (Mention crate being analyzed in query description) - rust-lang/rust#147155 (arm-linux.md: various fixes/improvements) - rust-lang/rust#147642 (Miscellaneous const-generics-related fixes) - rust-lang/rust#147806 (Ignore test-dashboard related files) - rust-lang/rust#147947 (Implement `strip_circumfix` lib feature) - rust-lang/rust#148346 (Change cfg_trace, cfg_attr_trace symbol values) - rust-lang/rust#148348 (dangling ptr lint cleanup) - rust-lang/rust#148393 (Remove `tests/run-make/fmt-write-bloat/`) - rust-lang/rust#148400 (Better warning message for crate type unsupported by codegen backend) r? `@ghost` `@rustbot` modify labels: rollup

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 28, 2025

rustbot assigned nnethercote Sep 28, 2025

nnethercote approved these changes Sep 28, 2025

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 13, 2025

estebank force-pushed the issue-74380 branch from be8f1aa to 0efeec5 Compare October 31, 2025 21:20

estebank added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 31, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 1, 2025

matthiaskrgr mentioned this pull request Nov 1, 2025

Rollup of 8 pull requests #148368

Closed

jhpratt mentioned this pull request Nov 2, 2025

Rollup of 12 pull requests #148376

Closed

Zalathar mentioned this pull request Nov 2, 2025

Rollup of 6 pull requests #148380

Closed

rust-bors bot added a commit that referenced this pull request Nov 2, 2025

Auto merge of #147137 - estebank:issue-74380, r=<try>

950a815

Mention crate being analyzed in query description try-job: armhf-gnu

matthiaskrgr mentioned this pull request Nov 2, 2025

Rollup of 9 pull requests #148404

Merged

bors merged commit 9758973 into rust-lang:master Nov 2, 2025
11 of 12 checks passed

rustbot added this to the 1.93.0 milestone Nov 2, 2025

Mention crate being analyzed in query description #147137

Mention crate being analyzed in query description #147137

Uh oh!

Conversation

estebank commented Sep 28, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Sep 28, 2025

Uh oh!

rustbot commented Sep 28, 2025

Uh oh!

nnethercote Sep 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nnethercote Sep 29, 2025

Choose a reason for hiding this comment

Uh oh!

nnethercote Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

estebank Oct 31, 2025

Choose a reason for hiding this comment

Uh oh!

nnethercote Nov 1, 2025

Choose a reason for hiding this comment

Uh oh!

nnethercote Sep 28, 2025

Choose a reason for hiding this comment

Uh oh!

estebank Sep 29, 2025

Choose a reason for hiding this comment

Uh oh!

rustbot commented Oct 13, 2025

Uh oh!

bors commented Oct 29, 2025

Uh oh!

rustbot commented Oct 31, 2025

Uh oh!

nnethercote commented Nov 1, 2025

Uh oh!

bors commented Nov 1, 2025

Uh oh!

Zalathar commented Nov 2, 2025

Uh oh!

rust-bors bot commented Nov 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Zalathar commented Nov 2, 2025

Uh oh!

rust-bors bot commented Nov 2, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

estebank commented Sep 28, 2025 •

edited by rustbot

Loading

nnethercote Sep 28, 2025 •

edited

Loading

rust-bors bot commented Nov 2, 2025 •

edited

Loading