- 
                Notifications
    You must be signed in to change notification settings 
- Fork 13.9k
fix 2 search graph bugs #147266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            fix 2 search graph bugs #147266
      
        
          +103
        
        
          −19
        
        
          
        
      
    
  
Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    we should not get the certainty from the current result of the provisional cache entry
  This was referenced Oct 2, 2025 
      
| @bors r=BoxyUwU rollup | 
    
  chenyukang 
      added a commit
        to chenyukang/rust
      that referenced
      this pull request
    
      Oct 14, 2025 
    
    
      
  
    
      
    
  
fix 2 search graph bugs wooooooooops, i should really run the fuzzer even when not changing the structure of the search graph as a whole :3 fixes the `ml-kem` ICE in the next-solver crater run r? `@BoxyUwU`
    
  Zalathar 
      added a commit
        to Zalathar/rust
      that referenced
      this pull request
    
      Oct 14, 2025 
    
    
      
  
    
      
    
  
fix 2 search graph bugs wooooooooops, i should really run the fuzzer even when not changing the structure of the search graph as a whole :3 fixes the `ml-kem` ICE in the next-solver crater run r? ``@BoxyUwU``
    
  Zalathar 
      added a commit
        to Zalathar/rust
      that referenced
      this pull request
    
      Oct 14, 2025 
    
    
      
  
    
      
    
  
fix 2 search graph bugs wooooooooops, i should really run the fuzzer even when not changing the structure of the search graph as a whole :3 fixes the `ml-kem` ICE in the next-solver crater run r? ```@BoxyUwU```
    
  bors 
      added a commit
      that referenced
      this pull request
    
      Oct 14, 2025 
    
    
      
  
    
      
    
  
Rollup of 11 pull requests Successful merges: - #146277 (Enable `u64` limbs in `core::num::bignum`) - #146976 (constify basic Clone impls) - #147249 (Do two passes of `handle_opaque_type_uses_next`) - #147266 (fix 2 search graph bugs) - #147468 (Implement fs api set_times and set_times_nofollow) - #147497 (`proc_macro` cleanups (3/N)) - #147594 (std: implement `pal::os::exit` for VEXos) - #147596 (Adjust the Arm targets in CI to reflect latest changes) - #147607 (GVN: Invalidate derefs at loop headers) - #147620 (Avoid redundant UB check in RangeFrom slice indexing) - #147647 (Hide vendoring and copyright in GHA group) r? `@ghost` `@rustbot` modify labels: rollup
    
  matthiaskrgr 
      added a commit
        to matthiaskrgr/rust
      that referenced
      this pull request
    
      Oct 14, 2025 
    
    
      
  
    
      
    
  
fix 2 search graph bugs wooooooooops, i should really run the fuzzer even when not changing the structure of the search graph as a whole :3 fixes the `ml-kem` ICE in the next-solver crater run r? `@BoxyUwU`
    
  matthiaskrgr 
      added a commit
        to matthiaskrgr/rust
      that referenced
      this pull request
    
      Oct 14, 2025 
    
    
      
  
    
      
    
  
fix 2 search graph bugs wooooooooops, i should really run the fuzzer even when not changing the structure of the search graph as a whole :3 fixes the `ml-kem` ICE in the next-solver crater run r? ``@BoxyUwU``
    
  matthiaskrgr 
      added a commit
        to matthiaskrgr/rust
      that referenced
      this pull request
    
      Oct 14, 2025 
    
    
      
  
    
      
    
  
fix 2 search graph bugs wooooooooops, i should really run the fuzzer even when not changing the structure of the search graph as a whole :3 fixes the `ml-kem` ICE in the next-solver crater run r? ```@BoxyUwU```
    
  matthiaskrgr 
      added a commit
        to matthiaskrgr/rust
      that referenced
      this pull request
    
      Oct 14, 2025 
    
    
      
  
    
      
    
  
fix 2 search graph bugs wooooooooops, i should really run the fuzzer even when not changing the structure of the search graph as a whole :3 fixes the `ml-kem` ICE in the next-solver crater run r? `````@BoxyUwU`````
  This was referenced Oct 14, 2025 
      
    
  bors 
      added a commit
      that referenced
      this pull request
    
      Oct 14, 2025 
    
    
      
  
    
      
    
  
Rollup of 12 pull requests Successful merges: - #146277 (Enable `u64` limbs in `core::num::bignum`) - #146976 (constify basic Clone impls) - #147249 (Do two passes of `handle_opaque_type_uses_next`) - #147266 (fix 2 search graph bugs) - #147497 (`proc_macro` cleanups (3/N)) - #147546 (Suppress unused_parens for labeled break) - #147548 (Fix ICE for never pattern as closure parameters) - #147594 (std: implement `pal::os::exit` for VEXos) - #147596 (Adjust the Arm targets in CI to reflect latest changes) - #147607 (GVN: Invalidate derefs at loop headers) - #147620 (Avoid redundant UB check in RangeFrom slice indexing) - #147647 (Hide vendoring and copyright in GHA group) r? `@ghost` `@rustbot` modify labels: rollup
    
  rust-timer 
      added a commit
      that referenced
      this pull request
    
      Oct 14, 2025 
    
    
      
  
    
      
    
  
Rollup merge of #147266 - lcnr:fix-search_graph, r=BoxyUwU fix 2 search graph bugs wooooooooops, i should really run the fuzzer even when not changing the structure of the search graph as a whole :3 fixes the `ml-kem` ICE in the next-solver crater run r? ````@BoxyUwU````
| Bors hasn't noticed that this was merged. @bors r- | 
      
        
      
      
  
    8 tasks
  
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
      
    S-waiting-on-author
  Status: This is awaiting some action (such as code changes or more information) from the author. 
  
    T-compiler
  Relevant to the compiler team, which will review and decide on the PR/issue. 
  
    WG-trait-system-refactor
  The Rustc Trait System Refactor Initiative (-Znext-solver) 
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
wooooooooops, i should really run the fuzzer even when not changing the structure of the search graph as a whole :3 fixes the
ml-kemICE in the next-solver crater runr? @BoxyUwU