Skip to content

Conversation

Enselic
Copy link
Member

@Enselic Enselic commented Oct 7, 2025

To make more of the test pass. It should not be necessary to disable this pass, but by doing it we can avoid further regressions while we figure out how to solve this use case properly.

We know this use case is sensitive to regressions because it already happened at least once. See #33013 (comment).

CC #130896

The last two FIXME(#33013) go away with #147462 in a completely different way (there will be trivial conflicts for me to resolve in basic-stepping.rs when one of them lands, but that's fine.)

To make more of the test pass. It should not be necessary to disable
this pass, but by doing it we can avoid further regressions while we
figure out how to solve this use case properly.

The last two `FIXME(33013)` didn't go away from this change, only the
first six. But that can be investigated separately.
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 7, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 7, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot

This comment has been minimized.

@Mark-Simulacrum
Copy link
Member

r? @saethlin

I'm personally dubious on disabling MIR passes in debuginfo tests... but I don't have the context here to really evaluate the tradeoffs.

@rustbot rustbot assigned saethlin and unassigned Mark-Simulacrum Oct 11, 2025
@Enselic
Copy link
Member Author

Enselic commented Oct 11, 2025

If we don't disable the pass, we can get other accidental regressions. If we disable the pass we at least know the situation will not get worse. And that risk of additional regressions is high since it already happened at least twice in the past.

Long term we should do a proper fix of course.

@saethlin
Copy link
Member

I'm very confused by the way you are describing this. If there are actual regressions happening in the behavior of the compiler, then what this PR does doesn't fix them. All it does is make sure the test suite keeps passing, which would make it easier for us to ship a regression.

@saethlin saethlin added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants