Skip to content

Unify and deduplicate max recip float tests #147818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Unify and deduplicate max recip float tests #147818

wants to merge 1 commit into from
+19 −19

Conversation

rperier
Copy link
Contributor

@rperier rperier commented Oct 17, 2025 •
edited by rustbot
Loading

cc #141726

This is a proposal to unify and deduplicate max recip tests for f16 and f128

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 17, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 17, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rperier
Copy link
Contributor Author

rperier commented Oct 17, 2025

r? tgross35

@rustbot rustbot assigned tgross35 and unassigned Mark-Simulacrum Oct 17, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 17, 2025

tgross35 is currently at their maximum review capacity.
They may take a while to respond.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rperier rperier force-pushed the unify_and_dedup_max_recip_float_tests branch from 8e132eb to 401c80f Compare October 17, 2025 18:49
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rperier rperier force-pushed the unify_and_dedup_max_recip_float_tests branch from 401c80f to cd0dfd9 Compare October 18, 2025 16:17
@rperier
Copy link
Contributor Author

rperier commented Oct 18, 2025

r? rust-lang/libs

@rustbot rustbot assigned ibraheemdev and unassigned tgross35 Oct 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@ibraheemdev ibraheemdev

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@rperier @rustbot @rust-log-analyzer @Mark-Simulacrum @tgross35 @ibraheemdev