Skip to content

Conversation

@pnkfelix
Copy link
Contributor

@pnkfelix pnkfelix commented Jan 8, 2015

int/uint -> isize/usize; i/u -> is/us

Authored by huon, some additional shepherding by pnkfelix.

[breaking-change]

@rust-highfive
Copy link
Contributor

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@pnkfelix
Copy link
Contributor Author

pnkfelix commented Jan 8, 2015

In my local make check run, it currently is up to rustc: x86_64-apple-darwin/stage2/test/rustctest-x86_64-apple-darwin

However, I have deliberately ignored a failing test: src/test/compile-fail/lifetime-inference-give-expl-lifetime-param-3.rs -- which seems to be a problem where a line break is being inserted by the pretty printer since the line has grown (with the int -> isize conversion), and the expected error output is not prepared for that line break.

@nikomatsakis
Copy link
Contributor

/me takes over

@nikomatsakis
Copy link
Contributor

See #20754

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants