Skip to content

Conversation

@steveklabnik
Copy link
Contributor

If these are useless, as @brson says #9070 (comment), we should just remove them.

Fixes #9070.

@rust-highfive
Copy link
Contributor

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

I'm not sure this is quite what @brson meant, but I'll let him chime in!

r? @brson

@rust-highfive rust-highfive assigned brson and unassigned alexcrichton Jan 21, 2015
@steveklabnik
Copy link
Contributor Author

Maybe not, but it wasn't a big deal to sed. 😄

@Gankra
Copy link
Contributor

Gankra commented Jan 21, 2015

So beautiful. ;_;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops. There are a few more of these.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought I went back in and manually fixed all of them. :(

@iKevinY
Copy link
Contributor

iKevinY commented Jan 21, 2015

Never mind; for some reason, I completely forgot that PRs can be merged simultaneously without breaking Travis. Resubmitted my fix as a PR against this repository.

@steveklabnik
Copy link
Contributor Author

@iKevinY you can also submit a PR to my PR

@iKevinY
Copy link
Contributor

iKevinY commented Jan 22, 2015

@steveklabnik Heh, I did that initially but then figured it was an unorthodox way of doing things. I've reopened my PR on your fork.

@brson
Copy link
Contributor

brson commented Jan 22, 2015

I would want to consult with @gerv before doing this. Although I believe my comment accurately represents what I've been told by our resident license experts, those same people also told us what to write in our license block. I will ping him.

@frewsxcv
Copy link
Contributor

Why are these lines being removed? It's what the Apache license explicitly says to add to each source file

@gerv
Copy link

gerv commented Jan 22, 2015

You can't remove them.

They are indeed legally near-useless; however, several licenses (which, I believe, include the ones Rust is using) require that they be preserved if they are present. E.g Apache License 2.0, section 4 c):

"You must retain, in the Source form of any Derivative Works that You distribute, all copyright, patent, trademark, and attribution notices from the Source form of the Work, excluding those notices that do not pertain to any part of the Derivative Works"

So unless you get the permission of all copyright holders, I'm afraid you are stuck with them :-(

Gerv

@Gankra
Copy link
Contributor

Gankra commented Jan 22, 2015

That sucks :(

Thanks for clarifying!

@Gankra Gankra closed this Jan 22, 2015
@gerv
Copy link

gerv commented Jan 22, 2015

Yeah, sorry :-(

@kmcallister
Copy link
Contributor

Should we at least stop putting it in new files? >__>

@Gankra
Copy link
Contributor

Gankra commented Jan 23, 2015

@brson has stated we can at least not increment any of the dates.

@frewsxcv
Copy link
Contributor

It might be okay to get rid of this text though? It's not explicitly mandated by Apache

See the COPYRIGHT file at the top-level directory of this distribution and at http://rust-lang.org/COPYRIGHT.

EDIT: I didn't mean to press send on this, disregard

@gerv
Copy link

gerv commented Jan 23, 2015

Yes, you could certainly not bother to increment the dates, and you could probably remove the "See the COPYRIGHT file" text if you thought it was unnecessary. But consistency is useful. That's the reason why it's probably not a good idea to stop putting a copyright line in the header on new files. The standard Apache boilerplate has a copyright line; if you want friction-free "Ah, it's Apache, I understand that" use, it's best to use the standard boilerplate.

This was referenced Jan 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ensure up-to-date copyright years

9 participants